Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 전체 사용자 조회 API 구현 #448

Merged
merged 3 commits into from
Oct 13, 2024
Merged

feat: 전체 사용자 조회 API 구현 #448

merged 3 commits into from
Oct 13, 2024

Conversation

mikekks
Copy link
Member

@mikekks mikekks commented Oct 9, 2024

👩‍💻 Contents

  • 전체 사용자 조회 API 구현했습니다.
  • 해당 기능은 모임 생성할 때, 멘션할 사용자 검색할 때 쓰이는 API 입니다.
  • 기존에 FE 에서 사용했던 멘션 사용자 조회 API전체 사용자 조회 API 로 마이그레이션 요청 드렸습니다!

📝 Review Note

📣 Related Issue

  • closed #

✅ 점검사항

  • docker-compose.yml 파일에 마이그레이션 한 API의 포워딩을 변경해줬나요?
  • Spring Secret 값을 수정하거나 추가했다면 Github Secret에서 수정을 해줬나요?
  • Nestjs Secret 값을 수정하거나 추가했다면 Docker-Compose.yml 파일 및 인스턴스 내부의 .env 파일을 수정했나요?

@mikekks mikekks added the 🎁 feature 새로운 기능 label Oct 9, 2024
@mikekks mikekks requested a review from hoonyworld October 9, 2024 01:29
@mikekks mikekks self-assigned this Oct 9, 2024
Copy link

height bot commented Oct 9, 2024

Link Height tasks by mentioning a task ID in the pull request title or commit messages, or description and comments with the keyword link (e.g. "Link T-123").

💡Tip: You can also use "Close T-X" to automatically close a task when the pull request is merged.

Copy link
Member

@hoonyworld hoonyworld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다~
이렇게 확정성 있게 바꾸면 나중에 재사용하기 좋을 것 같네요!!

@mikekks mikekks merged commit ce20f79 into develop Oct 13, 2024
1 check passed
@mikekks mikekks deleted the feat/#447 branch October 13, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎁 feature 새로운 기능 size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants