plugins: avoid crash on broken symlink #2545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SnoopJ
added
Bugfix
SnoopJ
force-pushed
the
bugfix/crash-on-broken-symlink
branch
4 times, most recently
from
9ddfa07 to
ef1358c
Compare
SnoopJ
force-pushed
the
bugfix/crash-on-broken-symlink
branch
from
ef1358c to
9e45e9a
Compare
dgw
reviewed
Nov 4, 2023
dgw
changed the title
dgw
approved these changes
Nov 5, 2023
There was a problem hiding this comment.
Checked on my test bot:
dgw@ROGAlly:~/github/sopel-irc/sopel$ sopel-plugins list
Plugin path does not exist, skipping: '/home/dgw/github/dgw/sopel-duel/duel.py'
admin/python-module admin.py - Sopel Admin Plugin (sopel.builtins.admin) [disabled]
[...]
Perfection. 👌
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This changeset adds a check that a plugin file actually exists on disk before it is added to the list of known plugins.
Closes #2269.
Checklist
make qa(runsmake lintandmake test)test_example_roll_4on 3.8, for which I have filed dice: local test failure on Python 3.8 #2544