Don't require pyenchant on Python 3.7 or above #1454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pyenchant is broken on newer distributions, and has been unmaintained for quite a while. Since only the spellcheck module needs it, and a rewrite of that module to switch libraries is coming Soon™, we might as well make Sopel installable in the mean time on systems that can't pull down a working pyenchant build. See #1452. Alternative to #1453.
|
Looks good to me, it will fix the installation using pip + git, which will enable devs to automate this process inside a virtualenv. Thanks @dgw |
|
Well, good enough I guess. @dgw go for it! |
|
Thanks for the feedback, both of you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pyenchant is broken on newer distributions, and has been unmaintained for quite a while. Since only the spellcheck module needs it, and a rewrite of that module to switch libraries is coming Soon™, we might as
well make Sopel installable in the mean time on systems that can't pull down a working pyenchant build.
See #1452. Alternative to #1453.
Note that this change is intended to make
masterinstallable, and there is no release planned between now and Sopel 7 (which will include the rewritten spellcheck module and drop pyenchant completely).