Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update links to new documentation #38

Merged
merged 3 commits into from
May 27, 2024

Conversation

Exirel
Copy link
Contributor

@Exirel Exirel commented May 2, 2022

This is related to PR 2257 of sopel-irc/sopel repo.

I tried to find all the possible links, so I may have miss some. The main two changes being:

  • db.html is now in package/db.html
  • config.html is now in package/config.html and the core section has its own file too

I also added a few links because I think they are appropriate and in-line with a more user-friendly approach to documentation.

This is related to PR2257 of sopel-irc/sopel repo.

See also: sopel-irc/sopel#2257
@dgw
Copy link
Member

dgw commented May 10, 2022

Is this meant to add redirects from the old to the new paths? I don't see those changes.

I also have to make extra sure that I don't merge this before the docs are updated. So if you don't mind, I'll convert it to a draft. 😁

@dgw dgw marked this pull request as draft May 10, 2022 17:11
@dgw dgw added this to the Sopel 8.0.0 milestone May 10, 2022
@dgw dgw added the content label May 10, 2022
@Exirel
Copy link
Contributor Author

Exirel commented May 10, 2022

Oh right, I forgot about redirect!

@Exirel
Copy link
Contributor Author

Exirel commented May 12, 2022

Redirects done. I think it should be enough. I'm not sure, it's always a bit hard to track everything: I looked at the files I moved, not the newly created.

Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I will have to hold off on actually merging this until the new Sopel version is out. Expect the base branch of this PR to be changed later, when there is a "Sopel 8" branch to merge it into with other updates (new migration guide etc.).

@Exirel
Copy link
Contributor Author

Exirel commented May 13, 2022

As expected!

@dgw dgw mentioned this pull request Nov 9, 2023
@dgw dgw mentioned this pull request May 27, 2024
@dgw dgw marked this pull request as ready for review May 27, 2024 00:36
@dgw
Copy link
Member

dgw commented May 27, 2024

Going to put all this into #47 after updating some of the underlying config/tooling (like the outdated Python version Netlify was configured to build with when this PR started).

@dgw dgw merged commit a5dfb6e into sopel-irc:master May 27, 2024
0 of 4 checks passed
@dgw
Copy link
Member

dgw commented May 27, 2024

…or I'll forget to change the base and merge to master instead. Whoops.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants