Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attach to framework tests #1322

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Attach to framework tests #1322

merged 10 commits into from
Jan 16, 2025

Conversation

ofirgo
Copy link
Collaborator

@ofirgo ofirgo commented Jan 13, 2025

Pull Request Description:

Unit tests for the Pytorch and Keras attach TPC to framework modules.
Also removing old TPC error tests that where already commented out.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@ofirgo ofirgo requested a review from irenaby January 13, 2025 11:01
@lior-dikstein lior-dikstein self-assigned this Jan 16, 2025
@ofirgo ofirgo merged commit 487a882 into sony:main Jan 16, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants