Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options blank/not syncing #6

Open
ixanga opened this issue May 21, 2013 · 12 comments
Open

Options blank/not syncing #6

ixanga opened this issue May 21, 2013 · 12 comments

Comments

@ixanga
Copy link

ixanga commented May 21, 2013

Since the most recent update, my options are blank on my Netbook. Options are sync'ed between machines. On a laptop, the options screen wouldn't even open. I deleted the ext and reinstalled it (since it was sync'd, it uninstalled and reinstalled on both machines). The default options came up and worked. On the Netbook, the Options are still blank and nothing either syncs or saves them. (I would like a Save button rather than just closing).

One another machine which was sync'd until I un/reinstalled the extension on the laptop and netbook, Tab Shepherd worked perfectly but didn't sync the options.

So, on the netbook, blank options, on the laptop, it is working now, on the second laptop, always was working, no change, no problems.

@sonntag
Copy link
Owner

sonntag commented May 22, 2013

What version of chrome are you using on each of the machines?

@ixanga
Copy link
Author

ixanga commented May 22, 2013

26.0.1410.64m on all machines.

On Tue, May 21, 2013 at 9:08 PM, Justin Sonntag [email protected]:

What version of chrome are you using on each of the machines?


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-18251700
.

@ixanga
Copy link
Author

ixanga commented May 22, 2013

My machines have all updated to 27.0.1453.93 and Tab Shepherd is working
fine on two of them. On the netbook where the options are blank and won't
save, they are still not saving, so I deleted it and went back to Tab
Wrangler which works fine. So long as I don't sync the computers (which I
prefer to do, but it isn't that important) I should be ok!

On Tue, May 21, 2013 at 11:26 PM, iXanga [email protected] wrote:

26.0.1410.64m on all machines.

On Tue, May 21, 2013 at 9:08 PM, Justin Sonntag [email protected]:

What version of chrome are you using on each of the machines?


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-18251700
.

@ixanga
Copy link
Author

ixanga commented May 22, 2013

Had to do a system restore on my main machine. Tab Shepherd stopped
working. Updated Chrome, un/reinstalled Tab Shepherd, options blank, won't
save new ones. Back on Tab Wrangler :-(

If you would rather I didn't send you bug reports just say so. I guess
these could get annoying!
Just let me know instead when you think I should try a new version of Tab
Shepherd which is a superb ext.

On Wed, May 22, 2013 at 2:16 PM, iXanga [email protected] wrote:

My machines have all updated to 27.0.1453.93 and Tab Shepherd is working
fine on two of them. On the netbook where the options are blank and won't
save, they are still not saving, so I deleted it and went back to Tab
Wrangler which works fine. So long as I don't sync the computers (which I
prefer to do, but it isn't that important) I should be ok!

On Tue, May 21, 2013 at 11:26 PM, iXanga [email protected] wrote:

26.0.1410.64m on all machines.

On Tue, May 21, 2013 at 9:08 PM, Justin Sonntag <[email protected]

wrote:

What version of chrome are you using on each of the machines?


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-18251700
.

@sonntag
Copy link
Owner

sonntag commented May 22, 2013

Haha sending me bug reports are no problem. I'd rather know that someone is having an issue than have no idea at all (or else I can't attempt to fix it).

Unfortunately, I'm still not sure what the problem could be. The Options tab not loading is a sign that there's something wrong with the settings storage mechanism (which is why saving wouldn't be working either), but without being able to reproduce it locally it's very hard for me to actually diagnose it.

If you get the chance, try right clicking on the TS button and click "Inspect Popup." Then at the bottom right corner see if a red X with a number appears. If so, click on it and see if you can copy paste the errors into here.

@ixanga
Copy link
Author

ixanga commented May 26, 2013

By the time this arrived, I had already installed Tab Wrangler, which
although it doesn't have the features of Tab Shepherd, is still pretty good
and is working. If I do reinstall Tab Shepherd I will do as you request and
send you any errors I can see.

Thanks for all your help.

On Wed, May 22, 2013 at 6:00 PM, Justin Sonntag [email protected]:

Haha sending me bug reports are no problem. I'd rather know that someone
is having an issue than have no idea at all (or else I can't attempt to fix
it).

Unfortunately, I'm still not sure what the problem could be. The Options
tab not loading is a sign that there's something wrong with the settings
storage mechanism (which is why saving wouldn't be working either), but
without being able to reproduce it locally it's very hard for me to
actually diagnose it.

If you get the chance, try right clicking on the TS button and click
"Inspect Popup." Then at the bottom right corner see if a red X with a
number appears. If so, click on it and see if you can copy paste the errors
into here.


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-18310919
.

@sonntag
Copy link
Owner

sonntag commented Jun 2, 2013

Alright sounds good. I'm going to resolve this for now since there's nothing more I can do on it. Please reopen if you get the chance to find any errors.

@sonntag sonntag closed this as completed Jun 2, 2013
@ixanga
Copy link
Author

ixanga commented Jun 2, 2013

Ok and thanks very much. You made a really great extension and I
appreciated it a lot, just a shame there is a conflict here somewhere.

On Sat, Jun 1, 2013 at 8:19 PM, Justin Sonntag [email protected]:

Alright sounds good. I'm going to resolve this for now since there's
nothing more I can do on it. Please reopen if you get the chance to find
any errors.


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-18799519
.

@ixanga
Copy link
Author

ixanga commented Jun 8, 2013

Hi Justin

Tab Wrangler has ceased to save the option not to delete all tabs on exit,
so I reinstalled Tab Shepherd which still doesn't save any options
whatsoever. Chrome version is 27.0.1453.110 m.

This is the error - Uncaught TypeError: Cannot read property 'length' of
undefined
popup.js:398chrome-extension://cfgaoapjfmfgcjdbfocfnfcgfoknlcjm/js/popup.js

So, it's back to Tab Wrangler and trying to remember to open all closed
tabs and save them via One Tab before I close the browser. Sometimes I
remember and sometimes not!

Have a good one

On Sun, May 26, 2013 at 1:55 PM, iXanga [email protected] wrote:

By the time this arrived, I had already installed Tab Wrangler, which
although it doesn't have the features of Tab Shepherd, is still pretty good
and is working. If I do reinstall Tab Shepherd I will do as you request and
send you any errors I can see.

Thanks for all your help.

On Wed, May 22, 2013 at 6:00 PM, Justin Sonntag [email protected]:

Haha sending me bug reports are no problem. I'd rather know that someone
is having an issue than have no idea at all (or else I can't attempt to fix
it).

Unfortunately, I'm still not sure what the problem could be. The Options
tab not loading is a sign that there's something wrong with the settings
storage mechanism (which is why saving wouldn't be working either), but
without being able to reproduce it locally it's very hard for me to
actually diagnose it.

If you get the chance, try right clicking on the TS button and click
"Inspect Popup." Then at the bottom right corner see if a red X with a
number appears. If so, click on it and see if you can copy paste the errors
into here.


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-18310919
.

@sonntag
Copy link
Owner

sonntag commented Jun 11, 2013

That is a very intriguing error, as assuming the google chrome APIs are working properly, it should not be possible... If you haven't already, you may want to try reinstalling google chrome and see if that fixes the issue.

As a side note, I am not a fan of how the settings system works in Tab Shepherd (it's one of the pieces that's left over from Tab Wrangler). I have a plan on how to fix it to make it work more reliably, and now that I know exactly what problem you're having, I should be able to prioritize fixing just that part.

@sonntag sonntag reopened this Jun 11, 2013
@ixanga
Copy link
Author

ixanga commented Jun 11, 2013

Thanks for your reply.

I don't think I could bear to reinstall Google together with all the
extensions. I don't have the settings messed around with much as the
extensions take care of it. If might try it though.

What would be nice is a Save button. That always adds a level of
confirmation.

I think it is a great extension. A nice feature would be to be able to
save all the urls as a web page a la One Tab. Then I can send them round to
everyone else who is working on the same things.

Thanks again

On Tue, Jun 11, 2013 at 2:37 PM, Justin Sonntag [email protected]:

That is a very intriguing error, as assuming the google chrome APIs are
working properly, it should not be possible... If you haven't already, you
may want to try reinstalling google chrome and see if that fixes the issue.

As a side note, I am not a fan of how the settings system works in Tab
Shepherd (it's one of the pieces that's left over from Tab Wrangler). I
have a plan on how to fix it to make it work more reliably, and now that I
know exactly what problem you're having, I should be able to prioritize
fixing just that part.


Reply to this email directly or view it on GitHubhttps://github.com//issues/6#issuecomment-19283186
.

@sonntag
Copy link
Owner

sonntag commented Jun 14, 2013

In general I like to minimize the number of steps that a user has to take to perform actions, and adding a save button would add an unnecessary step. The extension currently saves the settings whenever a setting changes, and there is temporary popup message which confirms that the settings were saved. As such, I do not see any benefit to adding a save button.

As for saving the urls as a web page, that sounds like a potentially useful feature, however I feel it's out of the scope of this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants