One-Time Run: Use notifier for invalid executable, Proton, and run directory #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Langfiles updated, version bumped, shellcheck is good, no regressions that I can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More work for #788.
When something goes wrong during a One-Time Run, there is some logging but it is not immediately obvious what went wrong visually. Users are expected to check the log to trace through execution and figure out what the problem is, but this PR adds a little bit of visual niceness using the notifier (if enabled, of course) and also uses
echoto detail when something went wrong.This is purely a quality-of-life improvement, with minimal functional change for One-Time Run. The only functional change added was to check to ensure an executable exists before trying to launch it, by adding a
&& [ -f "$OTEXE" ].TODO: