-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nxm urlscheme robustness #1096
Nxm urlscheme robustness #1096
Conversation
Awesome work! I'll review a little deeper when I'm on my PC, and give OP from #1093 some time to test the patch if they're able to. From a quick skim on my phone though and reading your description, it looks reasonable :-) This has been a longstanding issue, so getting it resolved will make plenty of people very happy. And either way I appreciate the time you took to contribute as well! Side note: Nice to see the CI working 😄 |
…ast written MO2*Conf file
dadfab6
to
a35017a
Compare
I think we can merge this as-is. I'd like to get this in before #1100, and I don't want to cause any more headaches with keeping this branch up-to-date. I think OP can test this on master when they are free to 🙂 I think the rebase went OK, if you see anything wrong with the diff, let me know :-) Thanks! |
Added credit to the changelog by updating the part that notes you improved the NXM link handling already, now it links to both PRs as they both help here: https://github.com/sonic2kk/steamtinkerlaunch/wiki/Changelog |
This PR fixes a few things with MO2 handling: