Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nxm urlscheme robustness #1096

Merged
merged 7 commits into from
May 3, 2024
Merged

Conversation

zerodogg
Copy link
Contributor

@zerodogg zerodogg commented Apr 28, 2024

This PR fixes a few things with MO2 handling:

  • There should no longer be an inconsistency between the last MO2 config written (global or portable) and STL's understanding of which MO2 variant was last used (global or portable)
  • Global instances now set the same vars as portable, which should fix launching global MO2s in those instances where it's missing the same vars as the portable was
  • It no longer writes useless broken portable config files when it can't figure out the game name
  • It'll fall back to using an AID to detect the game name, if one is present, which should fix those cases where MO2GAM for some reason isn't set (should fix MO2Conf files not written on launch of the app, issue with nxm:// links not resolved #1093)

@sonic2kk
Copy link
Owner

Awesome work! I'll review a little deeper when I'm on my PC, and give OP from #1093 some time to test the patch if they're able to. From a quick skim on my phone though and reading your description, it looks reasonable :-)

This has been a longstanding issue, so getting it resolved will make plenty of people very happy. And either way I appreciate the time you took to contribute as well!

Side note: Nice to see the CI working 😄

@sonic2kk sonic2kk force-pushed the nxm-urlscheme-robustness branch from dadfab6 to a35017a Compare May 3, 2024 20:00
@sonic2kk
Copy link
Owner

sonic2kk commented May 3, 2024

I think we can merge this as-is. I'd like to get this in before #1100, and I don't want to cause any more headaches with keeping this branch up-to-date. I think OP can test this on master when they are free to 🙂

I think the rebase went OK, if you see anything wrong with the diff, let me know :-)

Thanks!

@sonic2kk sonic2kk merged commit 59b421b into sonic2kk:master May 3, 2024
1 check passed
@sonic2kk
Copy link
Owner

sonic2kk commented May 3, 2024

Added credit to the changelog by updating the part that notes you improved the NXM link handling already, now it links to both PRs as they both help here: https://github.com/sonic2kk/steamtinkerlaunch/wiki/Changelog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MO2Conf files not written on launch of the app, issue with nxm:// links not resolved
2 participants