Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Langfiles: Remove remaining mentions of Cheat Engine #1008

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

sonic2kk
Copy link
Owner

Remove remaining mention of Cheat Engine from langfiles. These strings are unused, and were missed in f791df8.

@sonic2kk
Copy link
Owner Author

sonic2kk commented Jan 11, 2024

Will confirm that only CheatEngine-related strings were removed and do a quick test to ensure no crashes/regressions tomorrow. After that I will merge this. Should be a straightforward change.

There may be other unused language strings that I will check out and perhaps remove in a future PR, as a bit of a cleanup effort before v14.0.

@sonic2kk
Copy link
Owner Author

sonic2kk commented Jan 11, 2024

Langfile diff looks good, bumped the version, this should be fine to merge now. Did a quick launch test and didn't have any issues.

@sonic2kk sonic2kk merged commit 14d49e1 into master Jan 11, 2024
@sonic2kk sonic2kk deleted the remove-cheatengine-gameconqueror-strings branch January 12, 2024 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant