[PDDF] Make utilities compatible to platform API 2.0, in accordance with pddf_2.0 #940
+411
−100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 7 alerts when merging 45364adb29733530fc1dfbcf1b733eb642791c04 into a6c4456 - view on LGTM.com new alerts:
|
jleveque
suggested changes
Jul 7, 2020
…API 2.0, in accordance with pddf_2.0 Signed-off-by: Fuzail Khan <[email protected]>
|
restest this please |
|
I Fixed the LGTM errors |
jleveque
changed the title
jleveque
approved these changes
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Added PDDF utilities changes to make them compatible with 2.0 platform APIs. Since PDDF 2.0 is supporting platform 2.0 APIs, we needed to move the utilities to support the same.
- How I did it
Adding wrapper functions for various hw info retrieval
- How to verify it
Run PDDF utilities commands
- Previous command output (if the output of a command-line utility has changed)
Command o/p remains almost same. Please refer to
sonic-net/SONiC#536
- New command output (if the output of a command-line utility has changed)
Command o/p remains almost same.
sonic-net/SONiC#536
Depend on:
sonic-net/SONiC#536