-
Notifications
You must be signed in to change notification settings - Fork 684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sub port interface to config interface ip add/del
#651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
Signed-off-by: Wenda Ni <[email protected]>
jleveque
approved these changes
Sep 18, 2019
prsunny
approved these changes
Sep 18, 2019
config_db.set_entry("INTERFACE", (interface_name, ip_addr), {"NULL": "NULL"}) | ||
config_db.set_entry("INTERFACE", interface_name, {"NULL": "NULL"}) | ||
if VLAN_SUB_INTERFACE_SEPARATOR in interface_name: | ||
config_db.set_entry("VLAN_SUB_INTERFACE", interface_name, {"admin_status": "up"}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be it is good now to just set a table_name
here and use config_db.set_entry
once instead of repeated lines of same code.
retest this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Implement HLD sonic-net/SONiC#420
- How I did it
- How to verify it
On mlnx dut
default mode:
VLAN_SUB_INTERFACE
table is removed from CONFIG_DBalias mode:
VLAN_SUB_INTERFACE
table is removed from CONFIG_DB- Previous command output (if the output of a command-line utility has changed)
- New command output (if the output of a command-line utility has changed)
-->