-
Notifications
You must be signed in to change notification settings - Fork 675
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Multi ASIC support for apply-patch #3219
Add Multi ASIC support for apply-patch #3219
Conversation
config/main.py
Outdated
print("Patch: {}".format(patch)) | ||
# Iterate over each change in the JSON Patch | ||
for change in patch: | ||
asic_id, modified_path = extract_asic_id(change["path"]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if "path" not in change? #Resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
According to RFC: https://www.rfc-editor.org/rfc/rfc6902#section-4, operation objects MUST have exactly one "path" member.
config/main.py
Outdated
ctx.fail('Invalid IP address') | ||
db = ValidatedConfigDBConnector(ctx.obj['db']) | ||
db = ValidatedConfigDBConnector(ctx.obj['db']) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if "db" not in ctx.obj? #Resolved
Do we support HLD |
Yes, it will be in another further pr to address the HLD mentioned checkpoint and rollback part. |
What I did
Add Multi-ASIC GCU support apply-patch.
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)