-
Notifications
You must be signed in to change notification settings - Fork 669
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sonic_installer]: Improve exception handling: introduce notes. #3029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@stepanblyschak FYI |
stepanblyschak
approved these changes
Oct 30, 2023
1 task
nazariig
force-pushed
the
master-cli-exc
branch
from
November 1, 2023 10:59
1b5c7c5
to
b337d37
Compare
Signed-off-by: Nazarii Hnydyn <[email protected]>
nazariig
force-pushed
the
master-cli-exc
branch
from
November 1, 2023 11:46
b337d37
to
8130ef4
Compare
dgsudharsan
approved these changes
Nov 3, 2023
@prsunny / @qiluo-msft would you please help to review & merge? |
liat-grozovik
requested review from
saiarcot895
and removed request for
qiluo-msft and
volodymyrsamotiy
November 14, 2023 17:21
liat-grozovik
approved these changes
Nov 14, 2023
StormLiangMS
pushed a commit
that referenced
this pull request
Nov 15, 2023
What I did Extended exception class with user notes How I did it Implemented new API How to verify it Run UTs Tested branch (Please provide the tested image version) 202305 Details if related Backport from master: [sonic_installer]: Improve exception handling: introduce notes. #3029
@prsunny / @qiluo-msft just a kind reminder |
saiarcot895
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nazarii Hnydyn [email protected]
What I did
How I did it
How to verify it
Tested branch (Please provide the tested image version)
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)