check for vxlan mapping before removing vlan #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
check for vxlan mapping before removing vlan
|
|
prsunny
reviewed
Sep 23, 2022
config/vlan.py
Outdated
| @@ -60,6 +60,11 @@ def del_vlan(db, vid): | |||
|
|
|||
| if keys: | |||
| ctx.fail("VLAN ID {} can not be removed. First remove all members assigned to this VLAN.".format(vid)) | |||
|
|
|||
| vxlan_table = db.cfgdb.get_table('VXLAN_TUNNEL_MAP') | |||
There was a problem hiding this comment.
why do we have to set this restriction? will there be any ASIC failures?
There was a problem hiding this comment.
it is leaving behind vxtunnel maps in the configdb to vlans that have been removed. its messy
dgsudharsan
previously approved these changes
Sep 28, 2022
|
@ITJamie Can you please resolve conflicts? |
|
conflicts resolved |
|
tests are passing now |
dgsudharsan
approved these changes
Sep 29, 2022
prsunny
approved these changes
Sep 30, 2022
|
@ITJamie please raise separate PR for 202205. This PR cannot be cherry-picked cleanly. |
EdenGri
pushed a commit
to EdenGri/sonic-utilities
that referenced
this pull request
Oct 12, 2022
* [Vxlan] check for vxlan mapping before removing vlan
|
@ITJamie Can you please raise a PR for 202205? |
dgsudharsan
pushed a commit
to dgsudharsan/sonic-utilities
that referenced
this pull request
Oct 18, 2022
* [Vxlan] check for vxlan mapping before removing vlan
dgsudharsan
pushed a commit
to dgsudharsan/sonic-utilities
that referenced
this pull request
Oct 18, 2022
* [Vxlan] check for vxlan mapping before removing vlan
dgsudharsan
pushed a commit
to dgsudharsan/sonic-utilities
that referenced
this pull request
Oct 18, 2022
* [Vxlan] check for vxlan mapping before removing vlan
liat-grozovik
pushed a commit
that referenced
this pull request
Oct 18, 2022
mdanish-kh
pushed a commit
to hamnarauf/sonic-utilities
that referenced
this pull request
Oct 22, 2022
* [Vxlan] check for vxlan mapping before removing vlan
preetham-singh
pushed a commit
to preetham-singh/sonic-utilities
that referenced
this pull request
Nov 21, 2022
* [Vxlan] check for vxlan mapping before removing vlan
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #2381
What I did
check for vxlan mapping before removing vlan
How I did it
added a check similar to vlan member above
How to verify it
attempt to delete a vlan that has a vxlan mapping in place