portconfig option to configure Tx power and laser frequency of ZR transceiver module #2197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@qiluo-msft can you please review? |
qiluo-msft
reviewed
Jun 13, 2022
qiluo-msft
reviewed
Jun 13, 2022
qiluo-msft
reviewed
Jul 15, 2022
scripts/portconfig
Outdated
| sys.exit(1) | ||
| port.set_tx_power(args.port, args.tx_power) | ||
| if args.laser_freq: | ||
| if args.laser_freq < 1: |
qiluo-msft
reviewed
Jul 15, 2022
| @@ -307,6 +326,17 @@ def main(): | |||
| port.set_adv_interface_types(args.port, args.adv_interface_types) | |||
| if args.tpid: | |||
| port.set_tpid(args.port, args.tpid) | |||
| if args.tx_power: | |||
| d = decimal.Decimal(str(args.tx_power)) | |||
| if d.as_tuple().exponent < -1: | |||
qiluo-msft
reviewed
Jul 15, 2022
| sys.exit(1) | ||
| port.set_tx_power(args.port, args.tx_power) | ||
| if args.laser_freq: | ||
| if args.laser_freq <= 0: |
qiluo-msft
reviewed
Jul 15, 2022
tests/config_xcvr_test.py
Outdated
| result = self.basic_check("frequency", ["Ethernet0", "191300"], ctx) | ||
| assert "Setting laser frequency" in result.output | ||
| result = self.basic_check("frequency", ["Invalid", "191300"], ctx, op=operator.ne) | ||
| result = self.basic_check("frequency", ["Ethernet0", "-191300"], ctx, op=operator.ne) |
qiluo-msft
reviewed
Jul 15, 2022
tests/config_xcvr_test.py
Outdated
| result = self.basic_check("tx_power", ["Ethernet0", "27.3"], ctx) | ||
| assert "Setting target Tx output power" in result.output | ||
| result = self.basic_check("tx_power", ["Invalid", "27.3"], ctx, op=operator.ne) | ||
| result = self.basic_check("tx_power", ["Ethernet0", "27"], ctx) |
qiluo-msft
reviewed
Jul 15, 2022
tests/config_xcvr_test.py
Outdated
| #self.basic_check("link-training", ["Ethernet0", "on"], ctx) | ||
| result = self.basic_check("frequency", ["Ethernet0", "191300"], ctx) | ||
| assert "Setting laser frequency" in result.output | ||
| result = self.basic_check("frequency", ["Invalid", "191300"], ctx, op=operator.ne) |
qiluo-msft
approved these changes
Jul 19, 2022
|
@prgeor this PR cannot be cherry-picked cleanly, can you create separate PR for 202205? |
|
@prgeor can you create PR for 202205 ? |
prgeor
added a commit
to prgeor/sonic-utilities
that referenced
this pull request
Aug 23, 2022
…nsceiver module (sonic-net#2197) * New CLI option for configuring Xcvr frequency and Tx power * portconfig changes to configure xcvr's frequency and laser power * Added unit tests * Added check for tx_power and freq * Address review comment * Address review comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added new configuration CLI options to configure Tx power and laser frequency of ZR transceiver module
New command output (if the output of a command-line utility has changed)