[202012] [counterpoll] Display the correct default poll interval for watermark counters #2091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
approved these changes
Mar 11, 2022
liat-grozovik
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Mar 16, 2022
Advance sonic-utilities submodule to include the following changes 98de850 [muxcable][show] enhance show mux status to show last switchover time sonic-net/sonic-utilities#2067 3da82d1 [show][muxcable] fix the sudo access error for show muxcable metrics sonic-net/sonic-utilities#2083 7acbadb [build] stop vstest in the Azure pipeline sonic-net/sonic-utilities#2098 3fed440 [show][config] add muxcable command line support for retrieve / reset ICMP packet loss data sonic-net/sonic-utilities#2094 aa21e3a [202012] [counterpoll] Display the correct default poll interval for watermark counters sonic-net/sonic-utilities#2091 Signed-off-by: Neetha John <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to backport the changes in #2082
#2031 updated the flex counter polling interval to 60s for watermark counters but the show command wasn't updated to reflect the correct default value
What I did
Display the correct poll interval for watermark related counters in the 'counterpoll show' command
How I did it
Update the default interval to be the same as the one updated by the Orchs
How to verify it
Issue "counterpoll show", the queue, pg and buffer pool watermark should show default 60s
Updated the counterpoll unit tests to reflect the same