[201911][port2alias]: Fix to get right number of return values #1907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
from get_port_config. Modified to get ports from all namespaces. Signed-off-by: SuvarnaMeenakshi <[email protected]>
Signed-off-by: SuvarnaMeenakshi <[email protected]>
|
can we add ut ? |
|
@SuvarnaMeenakshi please add UT as part of another PR. Merging this as of now based on manual validation. |
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 28, 2022
3ce8119 (HEAD -> 201911, origin/201911) [201911][port2alias]: Fix to get right number of return values (sonic-net#1907) e648290 disk_Check: Scan & mount as RW when disk turns into Read-only (sonic-net#1872) Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
master branch PR: #1906
get_port_config was modified to return different set number of arguments in PR: sonic-net/sonic-buildimage#4222. Changes in this PR is:
To address the different set of return values
To get the ports from all namespaces
How I did it
Modify port2alias to read ports from all namespaces and also add unit-test
How to verify it
Tested on single and multi-asic platforms.
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)