[kdump] Remove automatic saving of kdump config in startup config #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warn user to save the config instead of saving the kdump config in config_db.json under the covers. Having more than one actors operate on config_db.json can result in an exception.
|
@dgsudharsan Please review |
|
This pull request introduces 3 alerts when merging b59ba2f into 9bc6500 - view on LGTM.com new alerts:
|
dgsudharsan
approved these changes
Oct 14, 2021
|
@lguohan Can you please review and merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix sonic-net/sonic-buildimage#8888
Warn user to save the config instead of saving the kdump config
in config_db.json under the covers. Having more than one actors
operate on config_db.json can result in an exception.
What I did
Remove automatic saving of kdump config in startup config. Warn user to save the config instead of saving the kdump config in config_db.json under the covers.
How I did it
Remove automatic saving of kdump config in startup config. Warn user to save the config instead of saving the kdump config in config_db.json under the covers.
How to verify it
config kdump enable
config kdump disable
config kdump memory
Previous command output (if the output of a command-line utility has changed)
root@sonic:/home/admin# config kdump disable
root@sonic:/home/admin# config kdump enable
root@sonic:/home/admin# config kdump memory 512M
New command output (if the output of a command-line utility has changed)
root@sonic:/home/admin# config kdump disable
KDUMP configuration changes may require a reboot to take effect.
Save SONiC configuration using 'config save' before issuing the reboot command.
root@sonic:/home/admin# config kdump enable
KDUMP configuration changes may require a reboot to take effect.
Save SONiC configuration using 'config save' before issuing the reboot command.
root@sonic:/home/admin# config kdump memory 0M-2G:256M,2G-4G:320M,4G-8G:384M,8G-:448M
KDUMP configuration changes may require a reboot to take effect.
Save SONiC configuration using 'config save' before issuing the reboot command.