[ecnconfig] Fix exception seen during display and add unit tests #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
…show/config Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yxieca
reviewed
Aug 27, 2021
yxieca
previously approved these changes
Aug 27, 2021
Signed-off-by: Neetha John <[email protected]>
yxieca
approved these changes
Aug 28, 2021
neethajohn
added a commit
to neethajohn/sonic-utilities
that referenced
this pull request
Aug 30, 2021
…ic-net#1784) Fixes sonic-net/sonic-buildimage#8323 and added unit tests for all ecn queue configs. This regression was caused because the current ecn unit tests didn't cover the queue configs. Signed-off-by: Neetha John <[email protected]> How to verify it Ran tests/ecn_test.py and all cases passed
qiluo-msft
pushed a commit
that referenced
this pull request
Sep 2, 2021
judyjoseph
pushed a commit
that referenced
this pull request
Sep 2, 2021
Fixes sonic-net/sonic-buildimage#8323 and added unit tests for all ecn queue configs. This regression was caused because the current ecn unit tests didn't cover the queue configs. Signed-off-by: Neetha John <[email protected]> How to verify it Ran tests/ecn_test.py and all cases passed
stepanblyschak
pushed a commit
to stepanblyschak/sonic-utilities
that referenced
this pull request
Apr 18, 2022
* d03ba4f [202012] [portstat, intfstat] added rates and utilization (sonic-net#1812) * 499ad3f [config reload] Fix config reload failure due to sonic.target job cancellation (sonic-net#1814) * 96d658c [202012][sonic installer] Add swap setup support (sonic-net#1815) * a9c6970 platform pre-check for reboot in 202012 branch (sonic-net#1788) * 0e0478b Unify the number format in the ourput of portstat and pfcstat in all cases (sonic-net#1795) * 2d1e00e [ecnconfig] Fix exception seen during display and add unit tests (sonic-net#1784) (sonic-net#1789) Signed-off-by: Volodymyr Samotiy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes sonic-net/sonic-buildimage#8323 and added unit tests for all ecn queue configs. This regression was caused because the current ecn unit tests didn't cover the queue configs.
How to verify it
Ran tests/ecn_test.py and all cases passed