Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vnet_route_check] don't hardcode prefix length of /24 #1756

Merged

Conversation

stepanblyschak
Copy link
Contributor

Signed-off-by: Stepan Blyschak [email protected]

What I did

Fix an issue when having /16 prefix on Vlan with vnet:

ERR vnet_route_check.py:  {'results': {'missed_in_app_db_routes': {'Vnet3': {'routes': ['172.3.255.254/32']}}}}
Interface     Master    IPv4 address/mask    Admin/Oper    BGP Neighbor     Neighbor IP
------------  --------  -------------------  ------------  ---------------  -------------
Loopback0               10.1.0.2/32          up/up         N/A              N/A
PortChannel1            10.100.0.16/31       up/up         TGS-SONIC-N2-S1  10.100.0.17
PortChannel2            10.100.0.18/31       up/up         TGS-SONIC-N2-S1  10.100.0.19
PortChannel3            10.100.0.20/31       up/up         TGS-SONIC-N2-S1  10.100.0.21
PortChannel4            10.100.0.22/31       up/up         TGS-SONIC-N2-S1  10.100.0.23
PortChannel5            10.100.0.24/31       up/up         PTR-SONIC-N2-S2  10.100.0.25
PortChannel6            10.100.0.26/31       up/up         PTR-SONIC-N2-S2  10.100.0.27
PortChannel7            10.100.0.28/31       up/up         PTR-SONIC-N2-S2  10.100.0.29
PortChannel8            10.100.0.30/31       up/up         PTR-SONIC-N2-S2  10.100.0.31
Vlan3         Vnet3     172.3.255.254/16     up/up         N/A              N/A
Vlan102                 22.144.1.254/16      up/up         N/A              N/A
docker0                 240.127.1.1/24       up/down       N/A              N/A
eth0                    10.144.253.130/16    up/up         N/A              N/A
lo                      127.0.0.1/8          up/up         N/A              N/A

How I did it

Avoid hardcoded /24 prefix.

How to verify it

Configure Vlan with /16 prefix and sudo vnet_route_check.py.

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Copy link
Contributor

@prsunny prsunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, could you please raise a PR to 201911 separate

@stepanblyschak
Copy link
Contributor Author

#1758

@prsunny prsunny merged commit 7821a3f into sonic-net:master Aug 13, 2021
qiluo-msft pushed a commit that referenced this pull request Aug 30, 2021
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 18, 2022
…627)

7041400 [config reload] Call systemctl reset-failed for snmp,telemetry,mgmt-framework services (sonic-net#1773) (sonic-net#1786)
399d370 Fix logic in RIF counters print (sonic-net#1732)
8329544 [vnet_route_check] don't hardcode prefix length of /24 (sonic-net#1756)
193b028 [neighbor-advertiser] delete the tunnel maps appropriately (sonic-net#1663)
2c82bcf [neighbor_advertiser] Use existing tunnel if present for creating tunnel mappings (sonic-net#1589)
8e22960 [202012][Config] Update config command of Kdump. (sonic-net#1778)
be3e5c6 [show][config] cli refactor for muxcable with abstract class implementation from vendors (sonic-net#1722) (sonic-net#1782)
stepanblyschak pushed a commit to stepanblyschak/sonic-utilities that referenced this pull request Apr 28, 2022
09457e524797bd988e011e24250a5e5c942bfdf2 (HEAD -> 201911, origin/201911)[tunneldecaporch] Set default MTU for the overlay loopback interface (sonic-net#1756)

Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants