Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[config/show] Add CLI support for proxy arp #1168

Merged
merged 3 commits into from
Oct 20, 2020
Merged

[config/show] Add CLI support for proxy arp #1168

merged 3 commits into from
Oct 20, 2020

Conversation

theasianpianist
Copy link
Contributor

@theasianpianist theasianpianist commented Oct 12, 2020 •
edited
Loading

Signed-off-by: Lawrence Lee [email protected]

- What I did
Enable CLI management for proxy ARP setting
- How I did it

  • Add `config vlan proxy_arp <enable/disable>
    • Edits VLAN_INTERFACE table to set the "proxy_arp" setting for an interface
    • Restarts the ndppd daemon running inside the SWSS container to grab changes
  • Add proxy ARP info to show vlan brief

- How to verify it

  • Run unit tests

- Previous command output (if the output of a command-line utility has changed)

> show vlan brief
+-----------+-----------------+------------+----------------+-----------------------+
|   VLAN ID | IP Address      | Ports      | Port Tagging   | DHCP Helper Address   |
+===========+=================+============+================+=======================+
|      1000 | 192.168.0.1/21  | Ethernet4  | untagged       | 192.0.0.1             |
|           | fc02:1000::1/64 | Ethernet8  | untagged       | 192.0.0.2             |
|           |                 | Ethernet12 | untagged       | 192.0.0.3             |
|           |                 | Ethernet16 | untagged       | 192.0.0.4             |
+-----------+-----------------+------------+----------------+-----------------------+
|      2000 | 192.168.0.10/21 | Ethernet24 | untagged       | 192.0.0.1             |
|           | fc02:1011::1/64 | Ethernet28 | untagged       | 192.0.0.2             |
|           |                 |            |                | 192.0.0.3             |
|           |                 |            |                | 192.0.0.4             |
+-----------+-----------------+------------+----------------+-----------------------+

- New command output (if the output of a command-line utility has changed)

> show vlan brief
+-----------+-----------------+------------+----------------+-----------------------+-------------+
|   VLAN ID | IP Address      | Ports      | Port Tagging   | DHCP Helper Address   | Proxy ARP   |
+===========+=================+============+================+=======================+=============+
|      1000 | 192.168.0.1/21  | Ethernet4  | untagged       | 192.0.0.1             | disabled    |
|           | fc02:1000::1/64 | Ethernet8  | untagged       | 192.0.0.2             |             |
|           |                 | Ethernet12 | untagged       | 192.0.0.3             |             |
|           |                 | Ethernet16 | untagged       | 192.0.0.4             |             |
+-----------+-----------------+------------+----------------+-----------------------+-------------+
|      2000 | 192.168.0.10/21 | Ethernet24 | untagged       | 192.0.0.1             | enabled     |
|           | fc02:1011::1/64 | Ethernet28 | untagged       | 192.0.0.2             |             |
|           |                 |            |                | 192.0.0.3             |             |
|           |                 |            |                | 192.0.0.4             |             |
+-----------+-----------------+------------+----------------+-----------------------+-------------+

@theasianpianist
[config/show] Add CLI support for proxy arp
e1ea26e 
* Add `config vlan proxy_arp <vid> <enable/disable>
* Add proxy ARP info to `show vlan brief`

Signed-off-by: Lawrence Lee <[email protected]>
@theasianpianist
Copy link
Contributor Author

retest default please

@theasianpianist
Copy link
Contributor Author

retest this please

2 similar comments
@theasianpianist
Copy link
Contributor Author

retest this please

@theasianpianist
Copy link
Contributor Author

retest this please

prsunny
prsunny reviewed Oct 15, 2020
View reviewed changes
config/vlan.py Show resolved Hide resolved
config/vlan.py Show resolved Hide resolved
@theasianpianist
Copy link
Contributor Author

retest this please

@theasianpianist theasianpianist merged commit 59a511d into sonic-net:master Oct 20, 2020
@theasianpianist theasianpianist deleted the proxy-arp-cli branch October 20, 2020 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prsunny prsunny prsunny approved these changes

@lguohan lguohan Awaiting requested review from lguohan

@jleveque jleveque Awaiting requested review from jleveque

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@theasianpianist @prsunny