Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix expected neighbor output when multiple ports connect to same neig… #1162

Merged
merged 2 commits into from
Oct 13, 2020

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Oct 11, 2020

…hbor

Previous code only enumerate on distinct neighbors, thus only one
port is shown for a neighbor.

Fix sonic-net/sonic-buildimage#5526

Signed-off-by: Guohan Lu [email protected]

- What I did
Previous code only enumerate on distinct neighbors, thus only one
port is shown for a neighbor.

- How I did it

  • Fix expected neighbor output when multiple ports connect to same neighbor
  • Add unit test
  • Add fixture to select t1 topology database
  • Introduce config/state/appl/asic/counter db for t1 topology

- How to verify it
Unit test and real dut

- Previous command output (if the output of a command-line utility has changed)

- New command output (if the output of a command-line utility has changed)

@lguohan lguohan requested a review from jleveque October 11, 2020 22:30
…hbor

Previous code only enumerate on distinct neighbors, thus only one
port is shown for a neighbor.

Signed-off-by: Guohan Lu <[email protected]>
Signed-off-by: Guohan Lu <[email protected]>
@lguohan
Copy link
Contributor Author

lguohan commented Oct 12, 2020

retest this please

@lguohan
Copy link
Contributor Author

lguohan commented Oct 13, 2020

test failure is due to a different issue

@lguohan lguohan merged commit b6af9f4 into sonic-net:master Oct 13, 2020
@lguohan lguohan deleted the nei branch October 13, 2020 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command "show interfaces neighbor expected" doesn't show all interfaces
2 participants