[202205][Auto-Techsupport] Fix the coredump_gen_handler Exception whe…

…n the History table is empty (#2265) (#2433)

What I did
BACKPORT OF: #2265

coredump_gen_handler script is throwing exception currently when the history table is empty.

root@r-lionfish-14:/home/admin# cat /tmp/coredump_gen_handler.log
Traceback (most recent call last):
  File "/usr/local/bin/coredump_gen_handler.py", line 82, in <module>
    main()
  File "/usr/local/bin/coredump_gen_handler.py", line 77, in main
    cls.handle_core_dump_creation_event()
  File "/usr/local/bin/coredump_gen_handler.py", line 60, in handle_core_dump_creation_event
    invoke_ts_command_rate_limited(self.db, EVENT_TYPE_CORE, {CORE_DUMP: self.core_name}, self.container)
  File "/usr/local/lib/python3.9/dist-packages/utilities_common/auto_techsupport_helper.py", line 331, in invoke_ts_command_rate_limited
    cooloff_passed = verify_rate_limit_intervals(db, global_cooloff, container_cooloff, container)
  File "/usr/local/lib/python3.9/dist-packages/utilities_common/auto_techsupport_helper.py", line 291, in verify_rate_limit_intervals
    if container_cooloff and container in ts_map:
TypeError: argument of type 'NoneType' is not iterable

Signed-off-by: Vivek Reddy Karri <[email protected]>

tests/coredump_gen_handler_test.py

@@ -450,3 +450,22 @@ def mock_cmd(cmd, env):
             cls = cdump_mod.CriticalProcCoreDumpHandle("orchagent.12345.123.core.gz", "swss", redis_mock)
             cls.handle_core_dump_creation_event()
 
+    def test_auto_ts_empty_state_db(self):
+        """
+        Scenario: Check if the techsupport is called as expected even when the history table in empty
+                  and container cooloff is non-zero
+        """
+        db_wrap = Db()
+        redis_mock = db_wrap.db
+        set_auto_ts_cfg(redis_mock, state="enabled", since_cfg="2 days ago")
+        set_feature_table_cfg(redis_mock, state="enabled", rate_limit_interval="300")
+        with Patcher() as patcher:
+            def mock_cmd(cmd, env):
+                cmd_str = " ".join(cmd)
+                if "show techsupport" in cmd_str and cmd_str != TS_DEFAULT_CMD:
+                    assert False, "Expected TS_CMD: {}, Recieved: {}".format(TS_DEFAULT_CMD, cmd_str)
+                return 0, AUTO_TS_STDOUT, ""
+            ts_helper.subprocess_exec = mock_cmd
+            patcher.fs.create_file("/var/core/orchagent.12345.123.core.gz")
+            cls = cdump_mod.CriticalProcCoreDumpHandle("orchagent.12345.123.core.gz", "swss", redis_mock)
+            cls.handle_core_dump_creation_event()

utilities_common/auto_techsupport_helper.py

@@ -257,7 +257,7 @@ def get_ts_map(db):
     ts_map = {}
     ts_keys = db.keys(STATE_DB, TS_MAP+"*")
     if not ts_keys:
-        return
+        return ts_map
     for ts_key in ts_keys:
         data = db.get_all(STATE_DB, ts_key)
         if not data: