[vs]: Add vs test support for bitmap VNET #792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Feb 15, 2019
|
There are some failures for the Vnet bitmap test, can you check? |
|
There are failures because implementation of "bitmap VNET" is not merged yet and also it depends on some other PRs.
|
prsunny
approved these changes
Mar 6, 2019
|
retest this please |
2 similar comments
|
retest this please |
|
retest this please |
volodymyrsamotiy
force-pushed
the
vnet_bitmap
branch
2 times, most recently
from
3eb2baa to
4ea372e
Compare
|
retest this please |
1 similar comment
|
retest this please |
added 3 commits
April 12, 2019 07:19
Signed-off-by: Volodymyr Samotiy <[email protected]>
* Move definition of bitmap VNET helper class to test_vnet.py Signed-off-by: Volodymyr Samotiy <[email protected]>
Signed-off-by: Volodymyr Samotiy <[email protected]>
volodymyrsamotiy
force-pushed
the
vnet_bitmap
branch
from
4ea372e to
3934760
Compare
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* [neighbor advertiser] remove http endpoint access Signed-off-by: Ying Xie <[email protected]> * Remove obsolete comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Volodymyr Samotiy [email protected]
What I did
Added
vstest support for bitmap VNET implementation.Why I did it
It is done in order to have
vstests running for the bitmap VNET implementation.How I verified it
Executed all
vstests (including this new test) and verified that all passed.Details if related
Depends on the following PRs: