Fix the tlm_teamd deleting STATE_DB LAG_TABLE entry. #3333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abdosi
changed the title
|
@anamehra for viz. |
abdosi
changed the title
|
LGTM, ran config reloads overnight (~130 config reloads) on Sup and did not hit the issue. |
|
@judyjoseph : can you help review this, |
judyjoseph
reviewed
Oct 21, 2024
|
/azp run |
|
Commenter does not have sufficient privileges for PR 3333 in repo sonic-net/sonic-swss |
|
@judyjoseph @abdosi can we merge this so that we can include this change in the newest nightly test |
anamehra
approved these changes
Oct 23, 2024
|
Cherry-pick PR to 202405: #3340 |
mssonicbld
added
Included in 202405 Branch
and removed
Created PR to 202405 Branch
labels
prsunny
pushed a commit
that referenced
this pull request
Oct 30, 2024
What I did: Original issue and and PR: #3333 Why I did: Fix the failure in test_po_update.py as seen in this PR checker: sonic-net/sonic-buildimage#20610 Previous fix blocked State Db LAG_MEMBER_TABLE deletion which is not correct as this table is created by tlm_teamd (owner). Intention was to prevent deletion of State Db LAG_TABLE owner of which is teamsyncd.
mssonicbld
pushed a commit
to mssonicbld/sonic-swss
that referenced
this pull request
Oct 30, 2024
What I did: Original issue and and PR: sonic-net#3333 Why I did: Fix the failure in test_po_update.py as seen in this PR checker: sonic-net/sonic-buildimage#20610 Previous fix blocked State Db LAG_MEMBER_TABLE deletion which is not correct as this table is created by tlm_teamd (owner). Intention was to prevent deletion of State Db LAG_TABLE owner of which is teamsyncd.
mssonicbld
pushed a commit
that referenced
this pull request
Oct 31, 2024
What I did: Original issue and and PR: #3333 Why I did: Fix the failure in test_po_update.py as seen in this PR checker: sonic-net/sonic-buildimage#20610 Previous fix blocked State Db LAG_MEMBER_TABLE deletion which is not correct as this table is created by tlm_teamd (owner). Intention was to prevent deletion of State Db LAG_TABLE owner of which is teamsyncd.
stepanblyschak
pushed a commit
to stepanblyschak/sonic-swss
that referenced
this pull request
Nov 13, 2024
What I did: Original issue and and PR: sonic-net#3333 Why I did: Fix the failure in test_po_update.py as seen in this PR checker: sonic-net/sonic-buildimage#20610 Previous fix blocked State Db LAG_MEMBER_TABLE deletion which is not correct as this table is created by tlm_teamd (owner). Intention was to prevent deletion of State Db LAG_TABLE owner of which is teamsyncd.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did: Original issue and and PR: sonic-net#3333 Why I did: Fix the failure in test_po_update.py as seen in this PR checker: sonic-net/sonic-buildimage#20610 Previous fix blocked State Db LAG_MEMBER_TABLE deletion which is not correct as this table is created by tlm_teamd (owner). Intention was to prevent deletion of State Db LAG_TABLE owner of which is teamsyncd.
divyachandralekha
pushed a commit
to divyachandralekha/sonic-swss
that referenced
this pull request
Dec 12, 2024
What I did: Original issue and and PR: sonic-net#3333 Why I did: Fix the failure in test_po_update.py as seen in this PR checker: sonic-net/sonic-buildimage#20610 Previous fix blocked State Db LAG_MEMBER_TABLE deletion which is not correct as this table is created by tlm_teamd (owner). Intention was to prevent deletion of State Db LAG_TABLE owner of which is teamsyncd.
shiraez
pushed a commit
to Marvell-switching/sonic-swss
that referenced
this pull request
Feb 17, 2025
What I did: Original issue and and PR: sonic-net#3333 Why I did: Fix the failure in test_po_update.py as seen in this PR checker: sonic-net/sonic-buildimage#20610 Previous fix blocked State Db LAG_MEMBER_TABLE deletion which is not correct as this table is created by tlm_teamd (owner). Intention was to prevent deletion of State Db LAG_TABLE owner of which is teamsyncd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Fixes:
sonic-net/sonic-buildimage#20059
Why I did:
On T2 testbed with multiple backend port channel we have seen sometime Portchannel gets created fine and with entry in APP_DB and STATE_DB gets populated. tlm_teamd is able to get the teamdctl handle to get state dump view of teamd. However while getting dump if might have passed in 1st iteration but it might fail in 2nd iteration (transient issue in getting data using teamdctl) which result in deletion of State db entry which is not correct. Instead we should just clean up local cache and wait for retry done as part of Select Timeout cycle where we try to get dump again.
How i verify:
Ran 20+ iteration of config reload and did not see the issue. Without fix issue will come within 1 or 2 iteration.