[pfcwd] Enhance DLR_INIT based recovery and DLR_PACKET_ACTION for broadcom platforms #2807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Neetha John <[email protected]>
Signed-off-by: Neetha John <[email protected]>
prsunny
reviewed
Jun 1, 2023
orchagent/pfcwdorch.cpp
Outdated
| @@ -238,11 +238,11 @@ task_process_status PfcWdOrch<DropHandler, ForwardHandler>::createEntry(const st | |||
| { | |||
| if(gSwitchOrch->checkPfcDlrInitEnable()) | |||
| { | |||
| if(getPfcDlrPacketAction() == PfcWdAction::PFC_WD_ACTION_UNKNOWN) | |||
| if((getPfcDlrPacketAction() == PfcWdAction::PFC_WD_ACTION_UNKNOWN) || m_pfcwd_ports.empty()) | |||
There was a problem hiding this comment.
What is this check on line 228? (action == PfcWdAction::PFC_WD_ACTION_UNKNOWN)
There was a problem hiding this comment.
The action value is initialized to unknown. This check was initially there to set the action for the first port and compare subsequent port actions and disallow if they do not match. The check is not needed anymore with the introduction of the 'm_pfcwd_ports' variable. Will remove that
Signed-off-by: Neetha John <[email protected]>
prsunny
approved these changes
Jun 4, 2023
yxieca
pushed a commit
that referenced
this pull request
Jun 7, 2023
…adcom platforms (#2807) Signed-off-by: Neetha John <[email protected]> What I did This PR contains the following changes * for brcm platforms that support DLR_INIT based recovery, use that method for both drop and forward action * While using DLR_INIT based recovery, do not update the pfc bitmask for that port * Update the logic to handle allowing drop/forward action on all ports without requiring a restart of swss * Mock tests for DLR_INIT and DLR_PACKET action Why I did it To provide support for DLR_INIT based pfcwd recovery on broadcom platforms in certain roles How I verified it * Mock tests * Tested on various brcm platforms (TD3 dual tor, Th2 T1, TD3 single tor) with a custom swss deb along with updated bcm config and verified that the pfcwd recovery mechanism is as expected on 202205 * Tested on td3 dual tor with custom deb along with updated bcm config and verified functionality working fine on internal branch
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 20, 2023
…adcom platforms (sonic-net#2807) Signed-off-by: Neetha John <[email protected]> What I did This PR contains the following changes * for brcm platforms that support DLR_INIT based recovery, use that method for both drop and forward action * While using DLR_INIT based recovery, do not update the pfc bitmask for that port * Update the logic to handle allowing drop/forward action on all ports without requiring a restart of swss * Mock tests for DLR_INIT and DLR_PACKET action Why I did it To provide support for DLR_INIT based pfcwd recovery on broadcom platforms in certain roles How I verified it * Mock tests * Tested on various brcm platforms (TD3 dual tor, Th2 T1, TD3 single tor) with a custom swss deb along with updated bcm config and verified that the pfcwd recovery mechanism is as expected on 202205 * Tested on td3 dual tor with custom deb along with updated bcm config and verified functionality working fine on internal branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
This PR contains the following changes
Why I did it
To provide support for DLR_INIT based pfcwd recovery on broadcom platforms in certain roles
How I verified it
Mock tests
Tested on various brcm platforms (TD3 dual tor, Th2 T1, TD3 single tor) with a custom swss deb along with updated bcm config and verified that the pfcwd recovery mechanism is as expected on 202205
Tested on td3 dual tor with custom deb along with updated bcm config and verified functionality working fine on internal branch
MSFT ADO: 17983504