Revert "Revert "[voq][chassis]Add show fabric counters port/queue com… #2652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mands (sonic-net#2522)" (sonic-net#2611)" This reverts commit b6bbc3e.
|
We need this revert in 202205 for chassis. The Broadcom SAI used in 202205 already has the corresponding changes to enable fabric counters. |
|
waiting for Brcm SAI 8.1.x or SAI 8.x to be in master branch |
arlakshm
approved these changes
Feb 4, 2023
|
Dont merge till fix is available in SAI 8.x |
6 tasks
|
I see the fix has landed in Brcm's SAI 8.4 release. |
|
@arlakshm the master branch is still pointing at 7.1.x and thus the fix is not available yet. |
theasianpianist
pushed a commit
to theasianpianist/sonic-swss
that referenced
this pull request
Jul 20, 2023
…mands (sonic-net#2522)" (sonic-net#2611)" (sonic-net#2652) This reverts commit b6bbc3e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mands (#2522)" (#2611)"
This reverts commit b6bbc3e.
Reverts https://github.com/sonic-net/sonic-swss/pull/](https://github.com/sonic-net/sonic-swss/pull/2611)
Before merging this revert, the Broadcom SAI needs to be updated to support fabric counters.