Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[hash]: Implement GH backend #2598

Merged
merged 2 commits into from
Jun 26, 2023
Merged

[hash]: Implement GH backend #2598

merged 2 commits into from
Jun 26, 2023

Conversation

nazariig
Copy link
Collaborator

@nazariig nazariig commented Jan 4, 2023 •
edited
Loading

Signed-off-by: Nazarii Hnydyn [email protected]

DEPENDS:

  1. [hash]: Add UT infra #2660
  2. [hash]: Add GH DB schema sonic-swss-common#733
  3. [hash]: Extend VS lib with ECMP/LAG hash sonic-sairedis#1192

HLD: sonic-net/SONiC#1101

What I did

  • Implemented Generic Hash feature

Why I did it

  • Implementation is done according to the Generic Hash HLD

How I verified it

  1. Run Generic Hash VS UTs

Details if related

  • N/A

@nazariig nazariig requested a review from prsunny as a code owner January 4, 2023 12:39
@nazariig nazariig mentioned this pull request Jan 4, 2023
Merged
@nazariig nazariig force-pushed the master-hash-rel branch 2 times, most recently from 818d875 to 8bf8a73 Compare January 16, 2023 16:19
@nazariig nazariig force-pushed the master-hash-rel branch 2 times, most recently from 6a66934 to 15c71b0 Compare February 14, 2023 10:30
@nazariig
Copy link
Collaborator Author

@prsunny could you please have a look?

@nazariig
Copy link
Collaborator Author

@prsunny just a kind reminder

3 similar comments
@nazariig
Copy link
Collaborator Author

@prsunny just a kind reminder

@nazariig
Copy link
Collaborator Author

nazariig commented Mar 9, 2023

@prsunny just a kind reminder

@nazariig
Copy link
Collaborator Author

@prsunny just a kind reminder

@nazariig nazariig requested a review from abdosi April 7, 2023 23:22
@nazariig nazariig force-pushed the master-hash-rel branch from 021cc2c to 96dc2bc Compare May 6, 2023 12:31
@nazariig
Copy link
Collaborator Author

nazariig commented May 9, 2023

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig nazariig force-pushed the master-hash-rel branch from 96dc2bc to a9ce172 Compare May 9, 2023 20:27
@nazariig
Copy link
Collaborator Author

/azpw run

@mssonicbld
Copy link
Collaborator

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@nazariig
Copy link
Collaborator Author

@prsunny so what's the plan here? Are we going to continue the review?

prsunny
prsunny requested changes May 13, 2023
View reviewed changes
orchagent/switch/swcap.cpp Outdated Show resolved Hide resolved
orchagent/switch/swcap.cpp Outdated Show resolved Hide resolved
orchagent/switch/swcnt.h Outdated Show resolved Hide resolved
orchagent/switch/swschema.h Outdated Show resolved Hide resolved
orchagent/switchorch.cpp Outdated Show resolved Hide resolved
orchagent/switchorch.cpp Outdated Show resolved Hide resolved
orchagent/switchorch.cpp Show resolved Hide resolved
orchagent/switchorch.cpp Outdated Show resolved Hide resolved
orchagent/switchorch.cpp Outdated Show resolved Hide resolved
orchagent/switchorch.cpp Show resolved Hide resolved
@nazariig
[hash]: Implement GH backend.
58f8df3 
Signed-off-by: Nazarii Hnydyn <[email protected]>
@nazariig nazariig force-pushed the master-hash-rel branch 2 times, most recently from 6849bce to fd7aeb5 Compare June 1, 2023 19:27
@nazariig
[hash]: Handle review comments.
2cc8534 
Signed-off-by: Nazarii Hnydyn <[email protected]>
@nazariig
Copy link
Collaborator Author

nazariig commented Jun 2, 2023

@prsunny review comments have been addressed. Please have a look.

@nazariig
Copy link
Collaborator Author

nazariig commented Jun 7, 2023

@prsunny just a kind reminder

1 similar comment
@nazariig
Copy link
Collaborator Author

@prsunny just a kind reminder

@prsunny prsunny merged commit a67f684 into sonic-net:master Jun 26, 2023
theasianpianist pushed a commit to theasianpianist/sonic-swss that referenced this pull request Jul 20, 2023
@nazariig @theasianpianist
[hash]: Implement GH backend (sonic-net#2598)
75dd6b5 
* [hash]: Implement GH backend as per HLD: sonic-net/SONiC#1101
@StormLiangMS
Copy link
Contributor

new feature, no backport

baxia-lan
baxia-lan reviewed Dec 5, 2023
View reviewed changes
orchagent/switchorch.cpp

sai_attribute_t attr;

attr.id = SAI_HASH_ATTR_NATIVE_HASH_FIELD_LIST;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have plan to support SAI_SWITCH_ATTR_ECMP_HASH_IPV4/SAI_SWITCH_ATTR_ECMP_HASH_IPV4_IN_IPV4/SAI_SWITCH_ATTR_ECMP_HASH_IPV6 /SAI_SWITCH_ATTR_LAG_HASH_IPV4/SAI_SWITCH_ATTR_LAG_HASH_IPV4_IN_IPV4/SAI_SWITCH_ATTR_LAG_HASH_IPV6 besides the default hash field list?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baxia-lan no. Implementation is according to the HLD. Also, this topic was discussed during Community design review and folks agreed that it requires some HLD/SAI extension in order to support hashing for different types of encapsulated frames per ASIC vendor. In any case, currently no plans to work on it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the heads up. Could you please provide the pointer of the HLD discussion recording for these concerns? Also if possible, could you please help me to clarify the SAI extension needed?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@baxia-lan regarding the recording, please speak to @zhangyanzhao

@byu343 byu343 mentioned this pull request Jun 15, 2024
Merged
8 tasks
StormLiangMS pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Jun 25, 2024
@byu343
Add loganalyzer_common_ignore regexs for config reload on broadcom (#…
2abfefc 
…13316)

What is the motivation for this PR?
These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

These are from the change sonic-net/sonic-swss#2598.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*"

How did you do it?
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jun 25, 2024
@byu343 @mssonicbld
Add loganalyzer_common_ignore regexs for config reload on broadcom (s…
bb31ce4 
…onic-net#13316)

What is the motivation for this PR?
These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

These are from the change sonic-net/sonic-swss#2598.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*"

How did you do it?
@mssonicbld mssonicbld mentioned this pull request Jun 25, 2024
Merged
8 tasks
mssonicbld pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Jun 25, 2024
@byu343 @mssonicbld
Add loganalyzer_common_ignore regexs for config reload on broadcom (#…
1bde5b3 
…13316)

What is the motivation for this PR?
These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

These are from the change sonic-net/sonic-swss#2598.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*"

How did you do it?
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jul 4, 2024
@byu343 @mssonicbld
Add loganalyzer_common_ignore regexs for config reload on broadcom (s…
420e672 
…onic-net#13316)

What is the motivation for this PR?
These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

These are from the change sonic-net/sonic-swss#2598.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*"

How did you do it?
@mssonicbld mssonicbld mentioned this pull request Jul 4, 2024
Merged
8 tasks
mssonicbld pushed a commit to sonic-net/sonic-mgmt that referenced this pull request Jul 7, 2024
@byu343 @mssonicbld
Add loganalyzer_common_ignore regexs for config reload on broadcom (#…
50cc5d0 
…13316)

What is the motivation for this PR?
These errors are found for config reload on 202311 branch on broadcom platform and safe to ignore.

These are from the change sonic-net/sonic-swss#2598.
r, ".* ERR swss#orchagent: :- queryHashNativeHashFieldListEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- queryHashNativeHashFieldListAttrCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchEcmpHashAlgorithmEnumCapabilities: Failed to get attribute."
r, ". ERR swss#orchagent: :- querySwitchLagHashAlgorithmEnumCapabilities: Failed to get attribute.*"

r, ".* ERR syncd\d*#syncd.SAI_API_PORT:_brcm_sai_read_fec_stat_err_counters. failed with error Feature unavailable.*"

How did you do it?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@baxia-lan baxia-lan baxia-lan left review comments

@prsunny prsunny prsunny approved these changes

@liat-grozovik liat-grozovik Awaiting requested review from liat-grozovik

@volodymyrsamotiy volodymyrsamotiy Awaiting requested review from volodymyrsamotiy

@abdosi abdosi Awaiting requested review from abdosi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nazariig @mssonicbld @StormLiangMS @baxia-lan @prsunny @dgsudharsan