[crmorch] Prevent exceededLogCounter from resetting when low and high values are equal #2327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgsudharsan
approved these changes
Jun 13, 2022
|
@prsunny could you please help to review? @volodymyrsamotiy FYI |
|
@alexrallen which branches we need this fix to get in? |
|
Lets have this in 202111 / 202205 that should be all. |
prsunny
approved these changes
Jun 14, 2022
judyjoseph
pushed a commit
that referenced
this pull request
Jun 20, 2022
… values are equal (#2327) * [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal
yxieca
pushed a commit
that referenced
this pull request
Jun 20, 2022
… values are equal (#2327) * [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal
7 tasks
preetham-singh
pushed a commit
to preetham-singh/sonic-swss
that referenced
this pull request
Aug 6, 2022
… values are equal (sonic-net#2327) * [crmorch] Prevent exceededLogCounter from resetting when low and high values are equal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Made the if / else if condition in the CRM logic mutually exclusive so that you cannot enter a state where the resource utilization does not change but the counter is constantly reset and the log is spammed with CRM messages.
Why I did it
If a user sets the "low" value and the "high" value equal to each other (a condition which is possible to be manually configured using the CLI or CONFIG_DB) the log will immediately get spammed with CRM messages because the counter will almost instantly reset even if the utilization does not change because the condition in the
ifstatement and the condition in theelse ifstatement can be true simultaneously.How I verified it
Manually tested by manually configuring a CRM resource
highandlowthreshold to be equal and verifying that the number of error logs seen does not exceed the max value.