Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled #1897

AkhileshSamineni · 2021-09-03T09:53:30Z

IPv6 link-local Neighbor deletion when ipv6 link-local mode is disabled

What I did
Fix for Issue => sonic-net/sonic-buildimage#8571:

Issue :
Step 1 : Enable the ipv6 link-local mode on Ethernet48 :

root@sonic:/home/admin# config interface ipv6 enable use-link-local-only Ethernet48
root@sonic:/home/admin# 
root@sonic:/home/admin# show ndp
Address    MacAddress    Iface    Vlan    Status
---------  ------------  -------  ------  --------
Total number of entries 0 
root@sonic:/home/admin# 
root@sonic:/home/admin#

Step 2 : Ping the ipv6 link-local neighbor :

root@sonic:/home/admin# 
root@sonic:/home/admin# ping fe80::ce37:abff:fe17:6c9a -I Ethernet48
ping6: Warning: source address might be selected on device other than Ethernet48.
PING fe80::ce37:abff:fe17:6c9a(fe80::ce37:abff:fe17:6c9a) from :: Ethernet48: 56 data bytes
64 bytes from fe80::ce37:abff:fe17:6c9a%Ethernet48: icmp_seq=1 ttl=64 time=0.623 ms
64 bytes from fe80::ce37:abff:fe17:6c9a%Ethernet48: icmp_seq=2 ttl=64 time=0.348 ms
64 bytes from fe80::ce37:abff:fe17:6c9a%Ethernet48: icmp_seq=3 ttl=64 time=0.339 ms
64 bytes from fe80::ce37:abff:fe17:6c9a%Ethernet48: icmp_seq=4 ttl=64 time=0.312 ms
^C
--- fe80::ce37:abff:fe17:6c9a ping statistics ---
4 packets transmitted, 4 received, 0% packet loss, time 67ms
rtt min/avg/max/mdev = 0.312/0.405/0.623/0.127 ms
root@sonic:/home/admin# 
root@sonic:/home/admin# show ndp
Address                    MacAddress         Iface       Vlan    Status
-------------------------  -----------------  ----------  ------  ---------
fe80::ce37:abff:fe17:6c9a  cc:37:ab:17:6c:9a  Ethernet48  -       REACHABLE
Total number of entries 1 
root@sonic:/home/admin#

Step 3 : Disable the ipv6 link-local mode on Ethernet48 :

root@sonic:/home/admin# config interface ipv6 disable use-link-local-only Ethernet48
root@sonic:/home/admin# 
root@sonic:/home/admin# show ndp
Address                    MacAddress         Iface       Vlan    Status
-------------------------  -----------------  ----------  ------  --------
fe80::ce37:abff:fe17:6c9a  cc:37:ab:17:6c:9a  Ethernet48  -       STALE
Total number of entries 1 
root@sonic:/home/admin#

Observed RIF is not getting deleted, as interface (Ethernet48) had an reference to ipv6 link-local neighbor.

root@sonic:/home/admin# bcmcmd 'l3 intf show'
l3 intf show
Free L3INTF entries: 8189
Unit  Intf  VRF Group VLAN    Source Mac     MTU TTL Tunnel InnerVlan  NATRealm
------------------------------------------------------------------
0     1     0     0     1    cc:37:ab:17:6c:e4  9100 0    0     0     0    
0     2     0     0     4095 cc:37:ab:17:6c:e4  9100 0    0     0     0    
drivshell>
root@sonic:/home/admin#

Why I did it
The ipv6 link local neighbors are getting added to APPL_DB only when ipv6 link local mode is enabled (Here : https://github.com/Azure/sonic-swss/blob/master/neighsyncd/neighsync.cpp#L85) and the added neighbor entry is not deleted when link-local mode is disabled. Because of APPL_DB neigh entry mapped to interface, the interface RIF is not getting deleted when ipv6 link-local mode is disabled.

Added code changes to delete the ipv6 link-local neigh entries when ipv6 link-local is disabled.

How I verified it

Enable and Disable link-local mode on a interface when global ipv6 address is not configured on an interface :

root@sonic:/home/admin# config interface ipv6 enable use-link-local-only Ethernet48
root@sonic:/home/admin# 
root@sonic:/home/admin# ping fe80::ce37:abff:fe17:6c9a -I Ethernet48 -c 3
ping6: Warning: source address might be selected on device other than Ethernet48.
PING fe80::ce37:abff:fe17:6c9a(fe80::ce37:abff:fe17:6c9a) from :: Ethernet48: 56 data bytes
64 bytes from fe80::ce37:abff:fe17:6c9a%Ethernet48: icmp_seq=1 ttl=64 time=0.662 ms
64 bytes from fe80::ce37:abff:fe17:6c9a%Ethernet48: icmp_seq=2 ttl=64 time=0.318 ms
64 bytes from fe80::ce37:abff:fe17:6c9a%Ethernet48: icmp_seq=3 ttl=64 time=0.319 ms

--- fe80::ce37:abff:fe17:6c9a ping statistics ---
3 packets transmitted, 3 received, 0% packet loss, time 55ms
rtt min/avg/max/mdev = 0.318/0.433/0.662/0.161 ms
root@sonic:/home/admin# 
root@sonic:/home/admin# show ndp
Address                    MacAddress         Iface       Vlan    Status
-------------------------  -----------------  ----------  ------  ---------
fe80::ce37:abff:fe17:6c9a  cc:37:ab:17:6c:9a  Ethernet48  -       REACHABLE
Total number of entries 1 
root@sonic:/home/admin# 
root@sonic:/home/admin# config interface ipv6 disable use-link-local-only Ethernet48
root@sonic:/home/admin# 
root@sonic:/home/admin# bcmcmd 'l3 intf show'
l3 intf show
Free L3INTF entries: 8190
Unit  Intf  VRF Group VLAN    Source Mac     MTU TTL Tunnel InnerVlan  NATRealm
------------------------------------------------------------------
0     1     0     0     1    cc:37:ab:17:6c:e4  9100 0    0     0     0    
drivshell>
root@sonic:/home/admin#

Enable and Disable link-local mode on a interface when global ipv6 address is configured on the same interface :

root@sonic:/home/admin# config interface ip add Ethernet48 1001::1/64
root@sonic:/home/admin# 
root@sonic:/home/admin# config interface ipv6 enable use-link-local-only Ethernet48
root@sonic:/home/admin# 
root@sonic:/home/admin# ping 1001::2
PING 1001::2(1001::2) 56 data bytes
64 bytes from 1001::2: icmp_seq=1 ttl=64 time=0.558 ms
64 bytes from 1001::2: icmp_seq=2 ttl=64 time=0.341 ms
^C
--- 1001::2 ping statistics ---
2 packets transmitted, 2 received, 0% packet loss, time 33ms
rtt min/avg/max/mdev = 0.341/0.449/0.558/0.110 ms
root@sonic:/home/admin# 
root@sonic:/home/admin# show ndp
Address                    MacAddress         Iface       Vlan    Status
-------------------------  -----------------  ----------  ------  ---------
1001::2                    cc:37:ab:17:6c:9a  Ethernet48  -       REACHABLE
fe80::ce37:abff:fe17:6c9a  cc:37:ab:17:6c:9a  Ethernet48  -       REACHABLE
Total number of entries 2 
root@sonic:/home/admin# 
root@sonic:/home/admin# 
root@sonic:/home/admin# config interface ipv6 disable use-link-local-only Ethernet48
root@sonic:/home/admin# 
root@sonic:/home/admin# 
root@sonic:/home/admin# config interface ip remove Ethernet48 1001::1/64
root@sonic:/home/admin# 
root@sonic:/home/admin# 
root@sonic:/home/admin# show ndp
Address                    MacAddress         Iface       Vlan    Status
-------------------------  -----------------  ----------  ------  ---------
fe80::ce37:abff:fe17:6c9a  cc:37:ab:17:6c:9a  Ethernet48  -       REACHABLE
Total number of entries 1 
root@sonic:/home/admin# 
root@sonic:/home/admin# 
root@sonic:/home/admin# bcmcmd 'l3 intf show'
l3 intf show
Free L3INTF entries: 8190
Unit  Intf  VRF Group VLAN    Source Mac     MTU TTL Tunnel InnerVlan  NATRealm
------------------------------------------------------------------
0     1     0     0     1    cc:37:ab:17:6c:e4  9100 0    0     0     0    
drivshell>
root@sonic:/home/admin#

Signed-off-by: Akhilesh Samineni [email protected]

Signed-off-by: Akhilesh Samineni <[email protected]>

AkhileshSamineni · 2021-09-24T06:03:03Z

@prsunny Please review the changes.

prsunny · 2021-09-24T16:15:06Z

@dgsudharsan , please review

dgsudharsan · 2021-09-27T20:44:01Z

cfgmgr/intfmgr.cpp

+            if (keys.size() == 2)
+            {
+                IpAddress ipAddress(keys[1]);
+                if ((ipAddress.isV4() == false) && (ipAddress.getAddrScope() == IpAddress::AddrScope::LINK_SCOPE))


Won't this isV4 check be a problem if the changes mentioned in these PR are merged? #1903

Removed the isV4 check.

dgsudharsan · 2021-09-27T20:45:58Z

@venkatmahalingam Can you also please review?

dgsudharsan

Can you please add vs test case covering the scenario?

Signed-off-by: Akhilesh Samineni <[email protected]>

AkhileshSamineni · 2021-10-22T15:09:19Z

Can you please add vs test case covering the scenario?

Added vs test case for this scenario.

AkhileshSamineni · 2021-10-23T05:10:13Z

@dgsudharsan Most of the vs test cases are failing due to some connection issue

2021-10-22T14:21:24.5804035Z RuntimeError: Unable to connect to redis (unix-socket): Cannot assign requested address

Please re-run it.

dgsudharsan · 2021-11-03T00:53:17Z

tests/test_ipv6_link_local.py

+
+        found_entry = False
+        for key in neigh_entries:
+            if (key.find("Ethernet4:2001::2") or key.find("Ethernet0:2000::2")):


Why is this an 'or' check? Shouldn't it be mandatory that both entries exist?

Both entries should exist, but here moving ahead by checking 1 entry only. Anyways checking number of entries as 4 right.

dgsudharsan · 2021-11-03T01:06:09Z

tests/test_ipv6_link_local.py

+        self.remove_ipv6_link_local_intf("Ethernet0")
+        self.remove_ipv6_link_local_intf("Ethernet4")
+
+        # Neigh entries should not contain Ipv6-link-local neighbors, should be 2


Wouldn't removing the global IPv6 remove both IP link local as well as global neighbor entries? Can you please clarify?

Global ipv6 remove will not remove the link local neighbor entries because ipv6 link local is always enable in kernel. The ipv6 link local remove command will remove the neighbors from APPL_DB only.

If it removes the neighbors from APPL_DB and remove_ip_address remove the global neighbors shouldn't the number of entries be zero? My earlier question was why 2 entries are present since the interface now has no IPv6 address (global) or has link local enabled.

@AkhileshSamineni Can you please let me know if my understanding is correct?

@dgsudharsan Global neighbor entries gets deleted when interface is set to down.
When interface set to up/down, then only the netlink message are generated (https://github.com/Azure/sonic-swss/blob/master/tests/test_neighbor.py#L79).

AkhileshSamineni · 2021-11-22T15:09:25Z

@dgsudharsan Please retest it.

dgsudharsan · 2021-11-22T15:32:50Z

@dgsudharsan Please retest it.

Akhilesh, I don't permissions. You can run it yourself by /azpw run (pipeline) e.g. /azpw run Azure.sonic-swss (Test vstest)

AkhileshSamineni · 2021-11-22T16:07:56Z

@dgsudharsan Please retest it.

Akhilesh, I don't permissions. You can run it yourself by /azpw run (pipeline) e.g. /azpw run Azure.sonic-swss (Test vstest)

Even I don't have permissions.

AkhileshSamineni · 2021-11-22T16:08:21Z

@prsunny Please retest it.

dgsudharsan · 2021-11-22T16:09:34Z

@dgsudharsan Please retest it.

Akhilesh, I don't permissions. You can run it yourself by /azpw run (pipeline) e.g. /azpw run Azure.sonic-swss (Test vstest)

Even I don't have permissions.

Hi Akhilesh
azpw is gives previleges for the user who raised PR. You should be able to do it.

AkhileshSamineni · 2021-11-22T16:16:48Z

/AzurePipelines run Azure.sonic-swss

azure-pipelines · 2021-11-22T16:16:54Z

Commenter does not have sufficient privileges for PR 1897 in repo Azure/sonic-swss

prsunny · 2021-11-22T18:19:35Z

@AkhileshSamineni , you could give "/azpw run"

prsunny · 2021-11-22T18:19:43Z

/azp run

azure-pipelines · 2021-11-22T18:19:53Z

Azure Pipelines successfully started running 1 pipeline(s).

dgsudharsan · 2021-11-22T22:14:00Z

@AkhileshSamineni The UT around the changes are failing. Can you please run them locally and fix?

AkhileshSamineni · 2021-11-23T09:12:57Z

@AkhileshSamineni The UT around the changes are failing. Can you please run them locally and fix?

@dgsudharsan Yeah sure, I have pushed the changes only after verified it locally.

Test case is failed as seeing 4 neighbor entries before ping operation.
neigh_before_entries = self.pdb.get_keys("NEIGH_TABLE")

  assert (len(neigh_before_entries) == 0)

E assert 4 == 0

AkhileshSamineni · 2021-11-24T13:06:51Z

@dgsudharsan @prsunny Corrected the vs test case.
Now I see below sub_port test cases are getting failed, not specific to this PR changes.

test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_removal FAILED [ 85%]
test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_mtu FAILED    [ 86%]
test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_nhg_accel FAILED [ 86%]
test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_oper_down_with_pending_neigh_route_tasks FAILED [ 86%]

Please check once.

prsunny · 2021-11-24T18:42:12Z

@dgsudharsan @prsunny Corrected the vs test case. Now I see below sub_port test cases are getting failed, not specific to this PR changes.

test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_removal FAILED [ 85%]
test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_mtu FAILED    [ 86%]
test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_nhg_accel FAILED [ 86%]
test_sub_port_intf.py::TestSubPortIntf::test_sub_port_intf_oper_down_with_pending_neigh_route_tasks FAILED [ 86%]

Please check once.

@preetham-singh , can you please check the test failures. Its now blocking other PRs. Is there any dependency that is missed?

AkhileshSamineni · 2021-11-25T06:01:10Z

/azpw run

mssonicbld · 2021-11-25T06:01:13Z

/AzurePipelines run

azure-pipelines · 2021-11-25T06:01:23Z

Azure Pipelines successfully started running 1 pipeline(s).

AkhileshSamineni · 2021-11-25T10:19:51Z

@prsunny @dgsudharsan Please approve and merge it.

prsunny · 2021-11-29T22:00:46Z

cfgmgr/intfmgr.cpp

+                IpAddress ipAddress(keys[1]);
+                if (ipAddress.getAddrScope() == IpAddress::AddrScope::LINK_SCOPE)
+                {
+                    m_neighTableProducer.del(neighKey);


This is not a good approach as to have multiple producers for the same table APP_NEIGH_TABLE_NAME (Owned by neighsyncd). I think, intfmgr should delete this from kernel directly. Is that feasible?

@prsunny I do agree about multiple producers to the same table.
If intfmgr deletes the kernel entry, then neighsync have to delete that entry from APPL_DB even though the link-local mode is disabled right. Added those changes, please continue the review.

prsunny · 2021-11-30T18:40:33Z

cfgmgr/intfmgr.cpp

+                    stringstream cmd;
+                    string res;
+
+                    cmd << IP_CMD << " neigh del dev " << keys[0] << " " << keys[1] ;


why don't we just do a flush of neigh on this interface? why to loop through each of the neighbors especially since this happens during a major config change

When we do flushing on a interface, the global ipv6 address also gets deleted along with link-local. For an example

root@sonic:/home/admin# root@sonic:/home/admin# ip neigh show 1001::2 dev Ethernet64 lladdr cc:37:ab:17:6c:9a router REACHABLE fe80::ce37:abff:fe17:6c9a dev Ethernet64 lladdr cc:37:ab:17:6c:9a router REACHABLE root@sonic:/home/admin# root@sonic:/home/admin# sonic-db-cli APPL_DB keys \*NEIGH\* NEIGH_TABLE:Ethernet64:1001::2 NEIGH_TABLE:Ethernet64:fe80::ce37:abff:fe17:6c9a root@sonic:/home/admin#

agree.. but this operation is not done frequently, and flushing the interface, it can also relearn, right?

Looks like this is deleting the link-local neighbor only, given that we will not have many link local neighbors, flushing per interface level may not be required.

ok, i was thinking if we could avoid this Neighbor handling and scanning the APP_DB in this context. @AkhileshSamineni, please make sure if the delete operation fails (for some reason the linklocal is not present in kernel while attempting to delete) does not cause process exit

@prsunny If the delete operation fails for some reason, it does not cause the process exit.
we see below INFO message only

Sep 5 13:00:00.887868 sonic INFO swss#/supervisord: intfmgrd RTNETLINK answers: No such file or directory

prsunny · 2021-12-01T03:04:53Z

@dgsudharsan , @venkatmahalingam , please signoff

691c37b [Route bulk] Fix bugs in case a SET operation follows a DEL operation in the same bulk (sonic-net/sonic-swss#2086) a4c80c3 patch for issue sonic-net/sonic-swss#1971 - enable Rx Drop handling for cisco-8000 (sonic-net/sonic-swss#2041) 71751d1 [macsec] Support setting IPG by gearbox_config.json (sonic-net/sonic-swss#2051) 5d5c169 [bulk mode] Fix bulk conflict when in case there are both remove and set operations (sonic-net/sonic-swss#2071) 8bbdbd2 Fix SRV6 NHOP CRM object type (sonic-net/sonic-swss#2072) ef5b35f [vstest] VS test failure fix after fabric port orch PR merge (sonic-net/sonic-swss#1811) 89ea538 Supply the missing ingress/egress port profile list in document (sonic-net/sonic-swss#2064) 8123437 [pfc_detect] fix RedisReply errors (sonic-net/sonic-swss#2040) b38f527 [swss][CRM][MPLS] MPLS CRM Nexthop - switch back to using SAI OBJECT rather than SWITCH OBJECT ae061e5 create debug_shell_enable config to enable debug shell (sonic-net/sonic-swss#2060) 45e446d [cbf] Fix max FC value (sonic-net/sonic-swss#2049) b1b5b29 Initial p4orch pytest code. (sonic-net/sonic-swss#2054) d352d5a Update default route status to state DB (sonic-net/sonic-swss#2009) 24a64d6 Orchagent: Integrate P4Orch (sonic-net/sonic-swss#2029) 15a3b6c Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled (sonic-net/sonic-swss#1897) ed783e1 [orchagent] Add trap flow counter support (sonic-net/sonic-swss#1951) e9b05a3 [vnetorch] ECMP for vnet tunnel routes with endpoint health monitor (sonic-net/sonic-swss#1955) bcb7d61 P4Orch: inital add of source (sonic-net/sonic-swss#1997) f6f6f86 [mclaglink] fix acl out ports (sonic-net/sonic-swss#2026) fd887bf [Reclaim buffer] Reclaim unused buffer for dynamic buffer model (sonic-net/sonic-swss#1910) 9258978 [orchagent, cfgmgr] Add response publisher and state recording (sonic-net/sonic-swss#1992) 3d862a7 Fixing subport vs test script for subport under VNET (sonic-net/sonic-swss#2048) fb0a5fd Don't handle buffer pool watermark during warm reboot reconciling (sonic-net/sonic-swss#1987) 16d4bcd Routed subinterface enhancements (sonic-net/sonic-swss#1907) 9639db7 [vstest/subintf] Add vs test to validate sub interface ingress to a vnet (sonic-net/sonic-swss#1642) Signed-off-by: Stephen Sun [email protected]

arlakshm · 2022-03-01T01:04:51Z

cherry-picking to 202106 is failing. Please create a new pr for the 202106 branch.

dgsudharsan · 2022-03-01T05:52:28Z

@AkhileshSamineni Can you please create a new PR?

…bled (sonic-net#1897) * IPv6 link-local Neighbor deletion when ipv6 link-local mode is disabled. Signed-off-by: Akhilesh Samineni <[email protected]>

IPv6 link-local Neighor deletion when ipv6 link-local mode is disabled.

3a63fff

Signed-off-by: Akhilesh Samineni <[email protected]>

AkhileshSamineni requested a review from prsunny as a code owner September 3, 2021 09:53

dgsudharsan requested changes Sep 27, 2021

View reviewed changes

liat-grozovik added the Request for 202106 Branch label Oct 18, 2021

Added vs test case.

08a4c8d

Signed-off-by: Akhilesh Samineni <[email protected]>

dgsudharsan reviewed Nov 3, 2021

View reviewed changes

dgsudharsan previously approved these changes Nov 22, 2021

View reviewed changes

Added few changes to vs test case

75ac751

AkhileshSamineni dismissed dgsudharsan’s stale review via 75ac751 November 23, 2021 09:20

AkhileshSamineni and others added 2 commits November 24, 2021 01:05

Updated vs test case

1b88e1a

Merge branch 'master' into ipv6_ll_neigh_delete

0ac9869

dgsudharsan previously approved these changes Nov 28, 2021

View reviewed changes

prsunny reviewed Nov 29, 2021

View reviewed changes

Added changes to delete the neigh entry from kernel

a77af5e

AkhileshSamineni dismissed dgsudharsan’s stale review via a77af5e November 30, 2021 10:31

prsunny reviewed Nov 30, 2021

View reviewed changes

prsunny approved these changes Dec 1, 2021

View reviewed changes

venkatmahalingam approved these changes Dec 1, 2021

View reviewed changes

prsunny merged commit 15a3b6c into sonic-net:master Dec 1, 2021

stephenxs mentioned this pull request Dec 1, 2021

[sonic-swss] Submodule update sonic-net/sonic-buildimage#9397

Merged

5 tasks

stephenxs mentioned this pull request Jan 6, 2022

[sonic-swss][202111] Submodule update (#9397) sonic-net/sonic-buildimage#9685

Merged

5 tasks

Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled #1897

Delete the IPv6 link-local Neighbor when ipv6 link-local mode is disabled #1897

Conversation

AkhileshSamineni commented Sep 3, 2021

AkhileshSamineni commented Sep 24, 2021

prsunny commented Sep 24, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

dgsudharsan commented Sep 27, 2021

dgsudharsan left a comment

Choose a reason for hiding this comment

AkhileshSamineni commented Oct 22, 2021

AkhileshSamineni commented Oct 23, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

AkhileshSamineni commented Nov 22, 2021

dgsudharsan commented Nov 22, 2021

AkhileshSamineni commented Nov 22, 2021

AkhileshSamineni commented Nov 22, 2021

dgsudharsan commented Nov 22, 2021

AkhileshSamineni commented Nov 22, 2021

azure-pipelines bot commented Nov 22, 2021

prsunny commented Nov 22, 2021

prsunny commented Nov 22, 2021

azure-pipelines bot commented Nov 22, 2021

dgsudharsan commented Nov 22, 2021

AkhileshSamineni commented Nov 23, 2021

AkhileshSamineni commented Nov 24, 2021

prsunny commented Nov 24, 2021

AkhileshSamineni commented Nov 25, 2021

mssonicbld commented Nov 25, 2021

azure-pipelines bot commented Nov 25, 2021

AkhileshSamineni commented Nov 25, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prsunny commented Dec 1, 2021

arlakshm commented Mar 1, 2022

dgsudharsan commented Mar 1, 2022