Dynamic Port Breakout system test cases using CLI command #1515

vasant17 · 2020-11-20T10:10:00Z

What I did
Wrote test cases using CLI command to breakout port

Why I did it
Better test coverage of DPB modules

How I verified it
Ran VS test cases

Details if related

$ sudo pytest --pdb -s -v --dvsname=vs-vp test_port_dpb_system.py
================================================================================== test session starts ==================================================================================
platform linux -- Python 3.6.9, pytest-6.1.2, py-1.9.0, pluggy-0.13.1 -- /usr/bin/python
cachedir: .pytest_cache
rootdir: /home/vapatil/workspace/AZURE_VS/sonic-buildimage/src/sonic-swss/tests
collected 29 items

test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G0] remove extra link dummy
PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]0] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G1] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)0] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G2] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)0] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x50G3] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]0] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]1] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)1] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]2] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)1] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-4x25G[10G]3] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]1] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)2] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)2] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-2x25G(2)+1x50G(2)3] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]2] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x50G(2)+2x25G(2)3] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_simple[Ethernet0-1x100G[40G]3] PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_with_vlan PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_port_breakout_with_acl PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_cli_command_with_force_option SKIPPED
test_port_dpb_system.py::TestPortDPBSystem::test_cli_command_with_load_port_breakout_config_option SKIPPED
test_port_dpb_system.py::TestPortDPBSystem::test_cli_command_negative PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_dpb_arp_flush PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_dpb_arp_flush_vlan PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_dpb_arp_flush_on_port_oper_shut PASSED
test_port_dpb_system.py::TestPortDPBSystem::test_dpb_arp_flush_on_vlan_member_remove PASSED

======================================================================= 27 passed, 2 skipped in 261.99s (0:04:21) =======================================================================
$

Dependent PRs:

sonic-net/sonic-buildimage#6029
sonic-net/sonic-utilities#1268
#1506 - Merged
sonic-net/sonic-buildimage#6034 - Merged

Signed-off-by: Vasant <[email protected]>

daall

The tests should poll (either by using the existing methods in dvs_database or wait_for_result in dvs_common), otherwise they aren't going to be stable.

tests/port_dpb.py

tests/test_port_dpb_system.py

Signed-off-by: Vasant <[email protected]>

tests/conftest.py

daall

Looking a lot better, just had a few more suggestions

tests/conftest.py

tests/port_dpb.py

daall · 2020-11-24T19:16:44Z

tests/test_port_dpb_system.py

+from swsscommon import swsscommon
+import redis


I don't think these are necessary w/ your latest round of changes

daall · 2020-11-24T19:17:12Z

tests/test_port_dpb_system.py

+import time
+import os
+import pytest
+from pytest import *


I don't think this is needed either - all the marks + whatnot should be covered by the import pytest.

tests/conftest.py

lguohan · 2020-11-26T04:41:33Z

retest this please

vasant17 · 2020-12-04T03:12:09Z

@zhenggen-xu: It would be good if we can commit the dependent PRs soon.

zhenggen-xu · 2021-01-22T04:33:42Z

retest this please

allas-nvidia · 2021-04-04T18:27:10Z

Can someone take a look, please?
Thanks.

zhenggen-xu · 2021-04-13T21:51:13Z

@vasant17 All dependent PRs are merged? Can you please rebase to solve the conflict?

…c-net#1515) Signed-off-by: Vasant <[email protected]> Co-authored-by: Danny Allen <[email protected]>

Dynamic Port Breakout system test cases using CLI command

e50e0a7

Signed-off-by: Vasant <[email protected]>

daall self-requested a review November 20, 2020 19:12

daall suggested changes Nov 23, 2020

View reviewed changes

Vasant added 2 commits November 24, 2020 09:29

Addressed code-review comments and some cleanup

c74ea49

Signed-off-by: Vasant <[email protected]>

Addressed code-review comments

e6b8da3

vasant17 commented Nov 24, 2020

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

Vasant added 2 commits November 24, 2020 09:53

Cleanup code

b24764a

Addressed code-review comments

f46b7a9

daall reviewed Nov 24, 2020

View reviewed changes

Addressed code-review comments

f1f6cb6

vasant17 commented Nov 24, 2020

View reviewed changes

tests/conftest.py Outdated Show resolved Hide resolved

Vasant added 2 commits November 24, 2020 22:33

Cleanup

6f3aeba

Cde cleanup

cf02a82

daall previously approved these changes Nov 24, 2020

View reviewed changes

Fixed bugs in skipped test cases

9dd24fb

vasant17 dismissed daall’s stale review via 9dd24fb November 25, 2020 04:57

Fixed bug in test_cli_command_negative and enabled the test case

c4e2d9f

zhenggen-xu added Port Breakout 🔱 Request for 202012 Branch labels Apr 15, 2021

Merge branch 'master' into DPB_SYSTEM_TEST

ea86c30

daall approved these changes May 4, 2021

View reviewed changes

daall merged commit 960eacf into sonic-net:master May 4, 2021

zhenggen-xu removed the Request for 202012 Branch label May 12, 2021

raphaelt-nvidia pushed a commit to raphaelt-nvidia/sonic-swss that referenced this pull request Oct 5, 2021

[dvs] Dynamic Port Breakout system test cases using CLI command (soni…

cbf5317

…c-net#1515) Signed-off-by: Vasant <[email protected]> Co-authored-by: Danny Allen <[email protected]>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dynamic Port Breakout system test cases using CLI command #1515

Dynamic Port Breakout system test cases using CLI command #1515

vasant17 commented Nov 20, 2020 •

edited

Loading

daall left a comment

daall left a comment

daall Nov 24, 2020

daall Nov 24, 2020

lguohan commented Nov 26, 2020

vasant17 commented Dec 4, 2020

zhenggen-xu commented Jan 22, 2021

allas-nvidia commented Apr 4, 2021

zhenggen-xu commented Apr 13, 2021

Dynamic Port Breakout system test cases using CLI command #1515

Dynamic Port Breakout system test cases using CLI command #1515

Conversation

vasant17 commented Nov 20, 2020 • edited Loading

Dependent PRs:

daall left a comment

Choose a reason for hiding this comment

daall left a comment

Choose a reason for hiding this comment

daall Nov 24, 2020

Choose a reason for hiding this comment

daall Nov 24, 2020

Choose a reason for hiding this comment

lguohan commented Nov 26, 2020

vasant17 commented Dec 4, 2020

zhenggen-xu commented Jan 22, 2021

allas-nvidia commented Apr 4, 2021

zhenggen-xu commented Apr 13, 2021

vasant17 commented Nov 20, 2020 •

edited

Loading