[vnet] Maintain the reference count of the nexthop when creating a vn… #1414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request introduces 2 alerts when merging d3b429f into c4949a2 - view on LGTM.com new alerts:
|
prsunny
previously approved these changes
Aug 27, 2020
prsunny
reviewed
Aug 27, 2020
| else if (nh.ips.getSize() == 1) | ||
| { | ||
| NextHopKey nexthop(nh.ips.to_string(), nh.ifname); | ||
| if (nexthop.ip_address.isZero()) |
There was a problem hiding this comment.
Minor comment - can you provide open and closing braces here and the below "if" condition?
prsunny
approved these changes
Aug 27, 2020
abdosi
pushed a commit
that referenced
this pull request
Sep 3, 2020
#1414) * [vnet] Maintain the reference count of the nexthop when creating a vnet route
EdenGri
pushed a commit
to EdenGri/sonic-swss
that referenced
this pull request
Feb 28, 2022
* Added ip and mask check to config int Signed-off-by: d-dashkov <[email protected]>
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-swss
that referenced
this pull request
Mar 1, 2023
Update SAI submodule v1.9 with the following fixes 7594e53 (HEAD, origin/v1.9) Skip brcm teardown assertion (sonic-net#1423) (sonic-net#1428) 0c33f4a [FIX]Fix the circular reference issue when build sai header py (sonic-net#1427) 7e0fc24 Add support for building under Doxygen 1.9.1 (sonic-net#1414) (sonic-net#1424) 8ecf3ef [Fix]Correct enum check on branch 1.9 (sonic-net#1418) e2b2f39 Add Thrift 0.14.1 compatibility (sonic-net#1403) (sonic-net#1416)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Maintain the reference count of the nexthop when creating a vnet route
Why I did it
Due to sequence problems or other reasons, the vnet route in ASIC_DB has not been deleted, and if you directly delete the related nexthop or interface, syncd will report an error.
swss#orchagent: :- meta_generic_validation_remove: object 0x600000000099a reference count is 1, can't remove
swss#orchagent: :- removeRouterIntfs: Failed to remove router interface for port Ethernet0, rv:-5
swss#supervisord: orchagent terminate called after throwing an instance of 'std::runtime_error'
swss#supervisord: orchagent what(): Failed to remove router interface.
How I verified it
Create a Vnet1
bind Ethernet0 to Vnet1
add ip for Ethernet0
add a route with the Ethernet0 as the next hop in Vnet1
delete ip and unbind Ethernet0
delete the route