[portsyncd] Remove the port_config.ini dependency from portsyncd #1107
Conversation
|
@qiluo-msft , do we have port_config.ini dependency with mellanox script? |
There was a problem hiding this comment.
In the same vein as Guohan I'd like to understand what is dependent on this -p option before we remove it. I agree that it does seem redundant now that the data should be available in config DB, but there could be scripts that currently depend on this option. We should at least give those folks a heads up first.
|
@lguohan @daall @qiluo-msft @prsunny This PR is not intended to remove the port_config.ini file itself. It just to break the dependencies of portsyncd with port_config.ini. port_config.ini would still exist for other purposes like transceiver show etc. I have some pending changes for the vs test cases and PR with sonic-buildimage along with this PR. Will send out soon. To remove port_config.ini completely, we are taking graceful steps and keep backwards compatible. We will introduce platform.json which was described in DPB design (sonic-net/SONiC#450). In case configDB does not have the information available, we will get from platform.json, but in the platforms/HWSKUs that still uses port_config.ini, the logic will keep the same. It will up to the platform vendors to add the platform.json for each platform/HWSKU and completely remove the port_config.ini. The code to use the new platform.json etc is coming out soon. In short, this PR should not break any functions unless you miss the PORT TABLE in configDB. |
|
Thanks for the explanation @zhenggen-xu! 🚀 |
portsyncd will rely on configDB port table, not from port_config.ini port_config.ini is used when we convert minigraph to configDB, then everything should come from configDB. Also for the DPB feature, we are going to deprecate port_config.ini Signed-off-by: Zhenggen Xu <[email protected]>
Signed-off-by: Zhenggen Xu <[email protected]>
zhenggen-xu
force-pushed
the
remove-portini
branch
from
3796a9a to
15be4ad
Compare
- Update SAI VoQ support (sonic-net#1107) … - Voq system (sonic-net#1081) … - [meta] Add support for ignored enum values (sonic-net#1099) - TPID SAI proposal (sonic-net#1089) … - ACL GRE key match (sonic-net#1076) … - Add IPv6 NS and NA Traps (sonic-net#1092) … - MACsec flow list attribute added in MACsec object (sonic-net#1095) … - Add Enterprise Number for IPFIX Report Type (sonic-net#1072) … - Provide TTL and QoS treatment during MPLS encap and decap (sonic-net#1079) - Create and Set for Tunnel Attributes (sonic-net#1086) …
Add SAI_PORT_ATTR_OPER_SPEED get in vslib.
If the SAI_PORT_ATTR_OPER_STATUS is DOWN, SAI_PORT_ATTR_OPER_SPEED should be 0, otherwise its value comes from /sys/class/net/eth{X}/speed
[portsyncd] Remove the port_config.ini dependency from portsyncd
portsyncd will rely on configDB port table, not from port_config.ini
port_config.ini is used when we convert minigraph to configDB, then
everything should come from configDB.
Also for the DPB feature, we are going to deprecate port_config.ini
Signed-off-by: Zhenggen Xu [email protected]
What I did
Remove the port_config.ini dependency from portsyncd
Why I did it
port_config.ini is used when we convert minigraph to configDB, then
everything should come from configDB.
Also for the DPB feature, we are going to deprecate port_config.ini
How I verified it
vs-test
Details if related