Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ConfigDBPipeConnector.get_config() implementation #446

Merged
merged 5 commits into from
Jan 17, 2021
Merged

Fix ConfigDBPipeConnector.get_config() implementation #446

merged 5 commits into from
Jan 17, 2021

Conversation

qiluo-msft
Copy link
Contributor

@qiluo-msft qiluo-msft commented Jan 14, 2021 •
edited
Loading

And simplify ConfigDBConnector/ConfigDBPipeConnector SWIG wrappers

Tested in unit test.
Tested config load_minigraph with minor code change on DUT.

@qiluo-msft
Fix ConfigDBPipeConnector.get_config() implementation
cfa32dd 
And simplify ConfigDBConnector/ConfigDBPipeConnector SWIG wrappers
@qiluo-msft qiluo-msft marked this pull request as ready for review January 14, 2021 02:48
@qiluo-msft qiluo-msft merged commit 2f79bb4 into sonic-net:master Jan 17, 2021
@qiluo-msft qiluo-msft deleted the qiluo/configdbfix branch January 17, 2021 02:40
@dmytroxshevchuk dmytroxshevchuk mentioned this pull request Mar 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lguohan lguohan lguohan approved these changes

@shi-su shi-su Awaiting requested review from shi-su

@kcudnik kcudnik Awaiting requested review from kcudnik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qiluo-msft @lguohan