Add RedisClient class and ScopeLogger class #2
Conversation
|
i remove the previous commit. so you could create a new pull request with just new files. |
kcudnik
changed the title
| @@ -27,6 +29,19 @@ class Logger | |||
| static Logger &getInstance(); | |||
| static void setMinPrio(Priority prio); | |||
| void write(Priority prio, const char *fmt, ...); | |||
|
|
|||
| class ScopeLogger | |||
There was a problem hiding this comment.
why define this inside the Logger class? why not outside of it?
There was a problem hiding this comment.
there is an issue to fully separate it from logger class since they both depend on each oder
There was a problem hiding this comment.
I think it's a very good patch, however, as Guohan wrote, I don't think it should be within Logger class.
In addition, it would be nice to expand this patch and include thread-id
|
|
||
| RedisClient(swss::DBConnector *db); | ||
|
|
||
| int64_t del(std::string key); |
There was a problem hiding this comment.
I'm not sure I understand why we need this class at all. We have started to implement generic function under Table.h.
Most of the suggested function are already implemented there (In your previous commit):
Table::del
Table::delField
Table::setField
There was a problem hiding this comment.
Table class will not provide all functionality that i need, and those functions from table will be removed later on
Help resolve review comments
Minor updates only
No description provided.