Add configDB table names to schema.h #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jipan Yang <[email protected]>
This was referenced Oct 21, 2017
|
@taoyl-ms to review. |
taoyl-ms
approved these changes
Oct 23, 2017
stcheng
reviewed
Oct 23, 2017
| /***** CONFIGUATION DATABASE *****/ | ||
| #define CFG_PORT_TABLE_NAME "PORT" | ||
| #define CFG_INTF_TABLE_NAME "INTERFACE" | ||
| #define CFG_LAG_INTF_TABLE_NAME "PORTCHANNEL_INTERFACE" |
There was a problem hiding this comment.
why we're using LAG in the TABLE name but PORTCHANNEL in the actual string?
There was a problem hiding this comment.
Using LAG in the TABLE name macro to be consistent with app and state DB, it is less confusing when writing code.
Real table name PORTCHANNEL_INTERFACE is from minigraph, would like to keep it as it is at least for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jipan Yang [email protected]