Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SNMP hardening - redis socket connect #281

Closed
wants to merge 4 commits into from
Closed

SNMP hardening - redis socket connect #281

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2aca44
SNMP hardening - redis socket connect
ycoheNvidia May 16, 2023
810a3ec
Merge branch 'sonic-net:master' into snmp_container_hardening
ycoheNvidia Jul 10, 2023
dcf8d20
Update __init__.py
ycoheNvidia Jul 27, 2023
a2ee6dd
use_unix_socket_path depending on other args
ycoheNvidia Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sonic_ax_impl/mibs/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,8 @@ def split_sai_id_key(sai_id_key):
def config(**kwargs):
ycoheNvidia marked this conversation as resolved.
Show resolved Hide resolved
global redis_kwargs
redis_kwargs = {k:v for (k,v) in kwargs.items() if k in ['unix_socket_path', 'host', 'port']}
if 'unix_socket_path' in redis_kwargs and 'host' in redis_kwargs and 'port' in redis_kwargs:
redis_kwargs['use_unix_socket_path'] = True
Copy link
Contributor

@SuvarnaMeenakshi SuvarnaMeenakshi Oct 9, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens if unix_socket_path or host is not present in redis_kwargs?
I see that with master branch image, redis_kwargs only has 'decode_responses' and with that the connection to redis fails.
If I add "use_unix_socket_path" to true in redis_kwargs, then the connection is successful and snmp_subagent comes up. Can you re-check if this works as expected ?

redis_kwargs['decode_responses'] = True

def init_db():
Expand Down