Support for MACsec statistics

[qbdwlr]

Build dependency on sonic-net/sonic-swss-common#520

[Pterosaur]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[qbdwlr]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[qbdwlr]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kcudnik]

to pass coverage.Azure.sonic-sairedis.amd64 you would need to add unittests at 50% for added code, can you also add unittests for your code?

[qbdwlr]

to pass coverage.Azure.sonic-sairedis.amd64 you would need to add unittests at 50% for added code, can you also add unittests for your code?

@kcudnik Can you point me to similar unittests for sairedis FlexCounter support?

[kcudnik]

you can start adding tests in sonic-sairedis/unittest/syncd path, creating file TestFlexCounter.cpp and follow pattern like for other files in sonic-sairedis/unittest/*, you would just need to cover like 50% of code added of this PR to pass the tests, you probably need to get familiar with gtest framework

[qbdwlr]

@kcudnik @Pterosaur I am only assigned to work on SONiC PRs for another week, so I cannot undertake providing all new coverage infrastructure for sairedis FlexCounters in the context of this PR. If coverage is now a requirement for sairedis PR approval, then Ze will have to take up that effort in a separate PR.

[qbdwlr]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[kcudnik]

@qbdwlr ok, then i can force merge this after tests passes, skipping coverage but it needs to be added later

[qbdwlr]

@kcudnik After rebasing to include latest commits to sairedis, I see the following failures in lgtm.com that are unrelated to any changes I introduced. Is this a known issue?
[2021-11-23 16:14:12] [build-stderr] saiaclschema_ut.cpp:1:10: fatal error: gmock/gmock.h: No such file or directory
[2021-11-23 16:14:12] [build-stderr] 1 | #include <gmock/gmock.h>
[2021-11-23 16:14:12] [build-stderr] | ^~~~~~~~~~~~~~~
[2021-11-23 16:14:12] [build-stderr] compilation terminated.

[kcudnik]

this is related to latest swss-common starting using gmock lib, it's attempted to be fixed here : 42e5427

[qbdwlr]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[qbdwlr]

@kcudnik @Pterosaur Can we get this PR approved/merged? Or do we have to wait for someone to fix these flaky vstests? I was able to re-use recently merged FlexCounter unittest infra to get >50% coverage for this PR, so that is no longer an issue.

[qbdwlr]

/azpw run

[mssonicbld]

/AzurePipelines run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[qbdwlr]

@kcudnik This PR is approved but hasn't been merged yet because vstests have been broken for two weeks. I don't see any fixes for vstest happening soon. Can this PR be merged despite the vstest failures?

[kcudnik]

ok