[fabric] Extend supported counter list in syncd's FlexCounter for fabric #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: ngocdo <[email protected]>
|
to have this always up to date even if SAI add new counters, we could use already generated metadata for sai_port_stat_t enum, and only use enums that value is less than SAI_PORT_STAT_IN_DROP_REASON_RANGE_BASE, then we actually include all enums, even if new added |
kcudnik
approved these changes
Oct 8, 2020
|
@daall to check out if there is any harm to do that, i think debug counters need to be configured. |
pettershao-ragilenetworks
pushed a commit
to pettershao-ragilenetworks/sonic-sairedis
that referenced
this pull request
Nov 18, 2022
New SAI version provides more counters for fabric ports. Extend the supported counter list to cover those counters.
/** SAI port stat if in FEC correctable pkts */
SAI_PORT_STAT_IF_IN_FEC_CORRECTABLE_FRAMES,
/** SAI port stat if in FEC not correctable pkts */
SAI_PORT_STAT_IF_IN_FEC_NOT_CORRECTABLE_FRAMES,
/** SAI port stat if in FEC symbol errors */
SAI_PORT_STAT_IF_IN_FEC_SYMBOL_ERRORS,
/** Fabric port stat in data units */
SAI_PORT_STAT_IF_IN_FABRIC_DATA_UNITS,
/** Fabric port stat out data units */
SAI_PORT_STAT_IF_OUT_FABRIC_DATA_UNITS,
/** Port stat in drop reasons range start */
SAI_PORT_STAT_IN_DROP_REASON_RANGE_BASE = 0x00001000,
Signed-off-by: ngocdo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New SAI version provides more counters for fabric ports. Extend the supported counter list to cover those counters.
Signed-off-by: ngocdo [email protected]