Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update latest v1.2 #264

Merged
merged 7 commits into from
Feb 21, 2018
Merged

update latest v1.2 #264

merged 7 commits into from
Feb 21, 2018

Conversation

lguohan
Copy link
Contributor

@lguohan lguohan commented Nov 28, 2017

No description provided.

@lguohan lguohan requested a review from kcudnik November 28, 2017 09:22
REDIS_GENERIC_QUAD_API(route_entry)

// TODO: upstream signiture fix to SAI repo
(sai_bulk_create_route_entry_fn)sai_bulk_create_route_entry,
Copy link
Collaborator

@kcudnik kcudnik Nov 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this is a cast ? is one of the params not matching ? #Resolved

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, const for pointer of pointer


In reply to: 153569444 [](ancestors = 153569444)

@kcudnik
Copy link
Collaborator

kcudnik commented Nov 28, 2017

cherrypick opencomputeproject/SAI@121d107 this commit from SAI master branch and it will fix stack protector issues

@@ -60,7 +60,7 @@ extern volatile bool g_useTempView;
extern volatile bool g_asicInitViewMode;
extern volatile bool g_logrotate;

extern service_method_table_t g_services;
extern sai_service_method_table_t g_services;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrong indentation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed.

@lguohan lguohan changed the title update latest v1.2 update latest v1.2 (DO NOT MERGE! It will break current SAI) Dec 1, 2017
@lguohan lguohan force-pushed the v1.2 branch 2 times, most recently from 44cf94f to a353dd6 Compare December 20, 2017 10:18
@lguohan lguohan force-pushed the v1.2 branch 4 times, most recently from 7fd1d19 to fafeb6a Compare January 17, 2018 04:16
@lguohan lguohan changed the title update latest v1.2 (DO NOT MERGE! It will break current SAI) update latest v1.2 Feb 21, 2018
@lguohan lguohan merged commit d2601d9 into sonic-net:master Feb 21, 2018
pettershao-ragilenetworks pushed a commit to pettershao-ragilenetworks/sonic-sairedis that referenced this pull request Nov 18, 2022
update sairedis/syncd to use SAI v1.2.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants