-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[saisubmodule] Update SAI submodule #1409
Conversation
@jimmyzhai Please update the PR description about adding serialize/deserialize change. |
@@ -118,6 +118,7 @@ namespace syncd | |||
.on_switch_asic_sdk_health_event = &Slot<context>::onSwitchAsicSdkHealthEvent, | |||
.on_port_host_tx_ready = &Slot<context>::onPortHostTxReady, | |||
.on_twamp_session_event = &Slot<context>::onTwampSessionEvent, | |||
.on_icmp_echo_session_state_change = nullptr, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other changes required due to SAI refpoint update?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other changes required due to SAI refpoint update?
No. Later let icmp echo feature owner implement its detail notification callback.
Just FYI I have a PR that updates the submodule + also updates sairedis code for the route group API changes #1410 |
done |
@jimmyzhai, there are some more changes in public sairedis repo that includes metering related changes. Could you please help include those as well in this PR? |
Please fix build errors |
Had tried that, but PR opencomputeproject/SAI#2056 for metering changes caused other sairedis build failure, which is not easy to handle in this PR. |
It depends on sonic-net/sonic-swss#3048, which has fix for outbound_routing_entry changes in swss. The sairedis PR won't pass without the swss change, but the swss PR also won't pass without the sairedis PR. It's a sort of circular dependency. After a discussion with Lawrence(theasianpianist), he had proposed the below solution:
|
Signed-off-by: Lawrence Lee <[email protected]>
* Update SAI submodule * Update NVDAMBF2H536C/dashapis.rec * Run new DASH VS tests Signed-off-by: Lawrence Lee <[email protected]> --------- Signed-off-by: Lawrence Lee <[email protected]> Co-authored-by: Lawrence Lee <[email protected]>
* Update SAI submodule * Update NVDAMBF2H536C/dashapis.rec * Run new DASH VS tests Signed-off-by: Lawrence Lee <[email protected]> --------- Signed-off-by: Lawrence Lee <[email protected]> Co-authored-by: Lawrence Lee <[email protected]>
Update SAI submodule to include opencomputeproject/SAI#2026, which updates outbound_routing_entry. It updates serialization/deserialization, test, etc for outbound_routing_entry.
Includes the following SAI commits: