Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[202205]Use warm-boot infrastructure for fast-boot #1121

Merged
merged 1 commit into from
Sep 14, 2022
Merged

[202205]Use warm-boot infrastructure for fast-boot #1121

merged 1 commit into from
Sep 14, 2022

Conversation

arfeigin
Copy link
Contributor

@arfeigin arfeigin commented Sep 8, 2022

This PR is similar to #1100 - it is being raised as a different PR following discussion with Ying Xie.

This PR should be merged together with sonic-utilities PR (sonic-net/sonic-utilities#2365) and sonic-buildimage PR (sonic-net/sonic-buildimage#12026).

Fast-reboot is utilizing warm-reboot infrastructure to improve its performance, but it should ignore warm-boot logic when syncd starts in fast-boot.
As well it shouldn't use temporary view between init and apply.

This was referenced Sep 8, 2022
Merged
Merged
@arfeigin
Copy link
Contributor Author

arfeigin commented Sep 8, 2022

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@arfeigin
Copy link
Contributor Author

arfeigin commented Sep 8, 2022

@vaibhavhd Please review - this is similar to the PR to master as described above.

@arfeigin arfeigin changed the title Use warm-boot infrastructure for fast-boot [202205]Use warm-boot infrastructure for fast-boot Sep 11, 2022
@arfeigin
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vaibhavhd
Copy link
Contributor

Please check and fix LGTM errors

vaibhavhd pushed a commit to sonic-net/sonic-utilities that referenced this pull request Sep 13, 2022
@arfeigin
Use warm-boot infrastructure for fast-boot (#2365)
d01153a 
This PR is similar to #2286

This PR should be merged together with the sonic-sairedis PR (sonic-net/sonic-sairedis#1121) and sonic-buildimage PR (sonic-net/sonic-buildimage#12026).

Improve fast-reboot flow by using warm-reboot infrastructure.
Clear all routes except of default routes for faster reconciliation time.

Verified by community fast-reboot test, manual testing.
@arfeigin
Copy link
Contributor Author

Please check and fix LGTM errors

Can you please assist with that? I couldn't understand what was the issue. In the LGTM it looks like an issue with a file that wasn't affected by this PR changes. As well in the original PR (#1100) LGTM checker passed on the exact changes.
I tried re-triggering the checkers but it looks like the LGTM didn't rerun as I assumed.

@arfeigin
Copy link
Contributor Author

/azpw run Azure.sonic-sairedis

@mssonicbld
Copy link
Collaborator

/AzurePipelines run Azure.sonic-sairedis

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vaibhavhd
Copy link
Contributor

Please check and fix LGTM errors

Can you please assist with that? I couldn't understand what was the issue. In the LGTM it looks like an issue with a file that wasn't affected by this PR changes. As well in the original PR (#1100) LGTM checker passed on the exact changes. I tried re-triggering the checkers but it looks like the LGTM didn't rerun as I assumed.

I can't conclusively tell the reason for this failure either. This may have to do something with swsscommon library in 202205 branch. I think this error is unrelated to your chagne.

[2022-09-14 15:59:13] [build-stderr] In file included from events.cpp:1:
[2022-09-14 15:59:13] [build-stderr] events_pi.h:10:10: fatal error: uuid/uuid.h: No such file or directory
[2022-09-14 15:59:13] [build-stderr]    10 | #include <uuid/uuid.h>
[2022-09-14 15:59:13] [build-stderr]       |          ^~~~~~~~~~~~~
[2022-09-14 15:59:13] [build-stderr] compilation terminated.
[2022-09-14 15:59:13] [build-stderr] make[3]: *** [Makefile:741: libswsscommon_la-events.lo] Error 1

@vaibhavhd vaibhavhd merged commit b080769 into sonic-net:202205 Sep 14, 2022
dprital added a commit to dprital/sonic-buildimage that referenced this pull request Sep 14, 2022
@dprital
[202205][submodule] Advance sonic-sairedis pointer
041e3c8 
Update sonic-sairedis submodule pointer to include the following:
* Use warm-boot infrastructure for fast-boot ([sonic-net#1121](sonic-net/sonic-sairedis#1121))

Signed-off-by: dprital <[email protected]>
@dprital dprital mentioned this pull request Sep 14, 2022
Merged
7 tasks
@liat-grozovik liat-grozovik mentioned this pull request Sep 20, 2022
Merged
skbarista pushed a commit to skbarista/sonic-sairedis that referenced this pull request Dec 2, 2022
@arfeigin @skbarista
Use warm-boot infrastructure for fast-boot (sonic-net#1121)
a98381e 
This PR is similar to sonic-net#1100 
This PR should be merged together with sonic-utilities PR (sonic-net/sonic-utilities#2365) and sonic-buildimage PR (sonic-net/sonic-buildimage#12026).

Fast-reboot is utilizing warm-reboot infrastructure to improve its performance, but it should ignore warm-boot logic when syncd starts in fast-boot.
As well it shouldn't use temporary view between init and apply.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaibhavhd vaibhavhd vaibhavhd approved these changes

@kcudnik kcudnik kcudnik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arfeigin @mssonicbld @vaibhavhd @kcudnik