Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass grid parameter while calling set_laser_freq #317

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

mihirpat1
Copy link
Contributor

@mihirpat1 mihirpat1 commented Nov 28, 2022

Description

It seems that with the below PR, a new parameter "grid" was added to set_laser_freq function. However, xcvrd is not passing this parameter and hence, we are seeing an error while calling set_laser_freq function for 400ZR transceiver. This task will ensure that we resolve the current error seen.

PR which triggers the error
sonic-net/sonic-platform-common#294

Error

Nov 28 21:19:28.258483 sonic INFO pmon#supervisord: xcvrd Process Process-1:
Nov 28 21:19:28.262677 sonic INFO pmon#supervisord: xcvrd Traceback (most recent call last):
Nov 28 21:19:28.262677 sonic INFO pmon#supervisord: xcvrd   File "/usr/lib/python3.9/multiprocessing/process.py", line 315, in _bootstrap
Nov 28 21:19:28.262677 sonic INFO pmon#supervisord: xcvrd     self.run()
Nov 28 21:19:28.263290 sonic INFO pmon#supervisord: xcvrd   File "/usr/lib/python3.9/multiprocessing/process.py", line 108, in run
Nov 28 21:19:28.263290 sonic INFO pmon#supervisord: xcvrd     self._target(*self._args, **self._kwargs)
Nov 28 21:19:28.263368 sonic INFO pmon#supervisord: xcvrd   File "/usr/local/lib/python3.9/dist-packages/xcvrd/xcvrd.py", line 1514, in task_worker
Nov 28 21:19:28.263395 sonic INFO pmon#supervisord: xcvrd     if 1 != self.configure_laser_frequency(api, lport, freq):
Nov 28 21:19:28.263434 sonic INFO pmon#supervisord: xcvrd   File "/usr/local/lib/python3.9/dist-packages/xcvrd/xcvrd.py", line 1307, in configure_laser_frequency
Nov 28 21:19:28.263458 sonic INFO pmon#supervisord: xcvrd     return api.set_laser_freq(freq)
Nov 28 21:19:28.263481 sonic INFO pmon#supervisord: xcvrd TypeError: set_laser_freq() missing 1 required positional argument: 'grid'

Motivation and Context

This change will help in resolving an error seen while bringing up 400ZR transceiver

How Has This Been Tested?

Link was verified on 400ZR transceiver and LLDP was verified as well.

root@sonic:/home/admin# show version

SONiC Software Version: SONiC.master.181162-f3809c217
Distribution: Debian 11.5
Kernel: 5.10.0-18-2-amd64
Build commit: f3809c217
Build date: Mon Nov 28 16:08:37 UTC 2022
Built by: AzDevOps@vmss-soni0001R9

Platform: x86_64-arista_7060dx4_32
HwSKU: Arista-7060DX4-C32
ASIC: broadcom
ASIC Count: 1
Serial Number: JPE19161053
Model Number: DCS-7060DX4-32
Hardware Revision: 04.00
Uptime: 22:53:07 up 24 min, 13 users,  load average: 1.42, 1.15, 0.93
Date: Mon 28 Nov 2022 22:53:07

root@sonic:/home/admin# show int status | grep Ethernet144                                                                                                
Ethernet144  145,146,147,148,149,150,151,152     400G   9100    N/A  Ethernet19/1   trunk      up       up  QSFP-DD Double Density 8X Pluggable Transceiver         N/A
root@sonic:/home/admin# show int status | grep Ethernet160
Ethernet160  161,162,163,164,165,166,167,168     400G   9100    N/A  Ethernet21/1   trunk      up       up  QSFP-DD Double Density 8X Pluggable Transceiver         N/A
root@sonic:/home/admin# show lldp t
Capability codes: (R) Router, (B) Bridge, (O) Other
LocalPort    RemoteDevice                  RemotePortID    Capability    RemotePortDescr
-----------  ----------------------------  --------------  ------------  ------------------------
Ethernet0    sonic                         Ethernet3/1     BR            Ethernet16
Ethernet16   sonic                         Ethernet1/1     BR            Ethernet0
Ethernet144  sonic                         Ethernet21/1    BR            Ethernet160
Ethernet160  sonic                         Ethernet19/1    BR            Ethernet144
eth0         STR43-0101-0100-01M0.phx.gbl  Ethernet1/31    BR            INFRA:MGMT:$Description$
--------------------------------------------------
Total entries displayed:  5
root@sonic:/home/admin# 

Additional Information (Optional)

Signed-off-by: Mihir Patel [email protected]

@mihirpat1 mihirpat1 marked this pull request as ready for review November 28, 2022 23:08
@mihirpat1 mihirpat1 requested a review from prgeor November 28, 2022 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants