-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add to check pcie configuration revision to get the right configuration. #195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Platform vendor can add their own logic to determine the pcie conifiguration revision.
jleveque
approved these changes
Jun 11, 2021
4 tasks
qiluo-msft
pushed a commit
that referenced
this pull request
Jun 16, 2021
…on. (#195) Platform vendor can add their own logic to determine the pcie conifiguration revision.
sujinmkang
added a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 16, 2021
…able name to match with pcied changes (#7886) Why I did it Support multiple pcie configuration file and change the pcie status table name This is to match with below two PRs. sonic-net/sonic-platform-common#195 sonic-net/sonic-platform-daemons#189 How I did it Check pcie configuration file with wild card and change the device status table name How to verify it Restart with changes and see if the pcie check works as expected.
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 17, 2021
…able name to match with pcied changes (#7886) Why I did it Support multiple pcie configuration file and change the pcie status table name This is to match with below two PRs. sonic-net/sonic-platform-common#195 sonic-net/sonic-platform-daemons#189 How I did it Check pcie configuration file with wild card and change the device status table name How to verify it Restart with changes and see if the pcie check works as expected.
sujinmkang
added a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 28, 2021
…1672) What I did Pcieutil to load the platform api first instead of using common api Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly. Please refer to the platform api support : sonic-net/sonic-platform-common#195 How I did it Load the platform pcie api first prior to use the common api
qiluo-msft
pushed a commit
to sonic-net/sonic-utilities
that referenced
this pull request
Jun 28, 2021
…1672) What I did Pcieutil to load the platform api first instead of using common api Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly. Please refer to the platform api support : sonic-net/sonic-platform-common#195 How I did it Load the platform pcie api first prior to use the common api
sujinmkang
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jun 29, 2021
Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
qiluo-msft
pushed a commit
to sonic-net/sonic-buildimage
that referenced
this pull request
Jul 14, 2021
Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…able name to match with pcied changes (sonic-net#7886) Why I did it Support multiple pcie configuration file and change the pcie status table name This is to match with below two PRs. sonic-net/sonic-platform-common#195 sonic-net/sonic-platform-daemons#189 How I did it Check pcie configuration file with wild card and change the device status table name How to verify it Restart with changes and see if the pcie check works as expected.
carl-nokia
pushed a commit
to carl-nokia/sonic-buildimage
that referenced
this pull request
Aug 7, 2021
…net#7875) Why I did it To determine the revision of the pcie.yaml to be used based on BIOS version in DellEMC S6100 platform. Depends on: sonic-net/sonic-platform-common#195 How I did it Added two revisions of pcie.yaml pcie_1.yaml and pcie_2.yaml Included a platform-specific Pcie class to provide the revision of the pcie.yaml to be used by pcieutil/pcied. How to verify it Execute pcieutil check (sonic-net/sonic-utilities#1672) command and verify the list of PCIe devices displayed. Logs: UT_logs.txt
raphaelt-nvidia
pushed a commit
to raphaelt-nvidia/sonic-utilities
that referenced
this pull request
Aug 10, 2021
…onic-net#1672) What I did Pcieutil to load the platform api first instead of using common api Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly. Please refer to the platform api support : sonic-net/sonic-platform-common#195 How I did it Load the platform pcie api first prior to use the common api
malletvapid23
added a commit
to malletvapid23/Sonic-Utility
that referenced
this pull request
Aug 3, 2023
…#1672) What I did Pcieutil to load the platform api first instead of using common api Some platform device with different BIOS version needs more than one pcie configuration to check the pcie devices properly. Please refer to the platform api support : sonic-net/sonic-platform-common#195 How I did it Load the platform pcie api first prior to use the common api
oleksandrivantsiv
pushed a commit
to oleksandrivantsiv/sonic-platform-common
that referenced
this pull request
Oct 25, 2024
This PR adds support for logging required in debugging events for change/probe requests received by xcvrd from swss and linkmgr into state DB. a typical log would look like this: Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: trying to enable/disable debug logs Jun 17 05:55:39.302379 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: received an event for port transition Ethernet4 Jun 17 05:55:39.302575 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: xcvrd trying to transition port Ethernet4 from standby to active Jun 17 05:55:39.307872 NOTICE pmon#xcvrd[33]: Y_CABLE_DEBUG: Successful in toggling mux to ToR A for port 2 where both probe events and change events are logged inside xcvrd. Motivation and Context This is required for xcvrd to log the events which it receives from other modules when we want to see the completion of events as to what triggered the event and at which stage it failed without restarting pmon/xcvrd Signed-off-by: vaibhav-dahiya <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add to check the Pcie configuration revision to get the right configuration.
Platform vendor can add their own logic to determine the Pcie
configuration revision.
Motivation and Context
How Has This Been Tested?
Additional Information (Optional)