-
Notifications
You must be signed in to change notification settings - Fork 771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fdb_mac_expire.yml]: FDB MAC Expire test case. #785
Conversation
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table. [fdb.yml]: include fdb_mac_expire.yml. This test case verifies that MAC expires within 10 mins if traffic is not flowing using it. Signed-off-by: Praveen Chaudhary<[email protected]>
we are using run test by name? need you to add into the testcases.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as comments
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table. [testcases.yml]: include fdb_mac_expire.yml. This test case verifies that MAC expires within 10 mins if traffic is not flowing using it. Signed-off-by: Praveen Chaudhary<[email protected]>
…mgmt into fdb_mac_expire
…mer in fdb_mac_expire.yml Signed-off-by: Praveen Chaudhary<[email protected]>
Signed-off-by: Praveen Chaudhary<[email protected]>
Example: "MAC Entires are Cleared within 100 secs." instead of "MAC Entires are Cleared within 2*50 secs." Signed-off-by: Praveen Chaudhary<[email protected]>
… -it option and block-always. Signed-off-by: Praveen Chaudhary<[email protected]>
Addressed all review comments, kindly review the latest code. Thx. |
Kindly merge, all issues are resolved for this .Thanks. |
@lguohan : Kindly help in merging this one, I see all issues are resolved and it is approved by Prince. Thanks. |
@lguohan : Kindly help in merging this one, I see all issues are resolved and it is approved by Prince. Thanks a lot. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor issues on comments
Signed-off-by: Praveen Chaudhary<[email protected]>
* [fdb_mac_expire.yml]: FDB MAC Expire test case. [fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table. [fdb.yml]: include fdb_mac_expire.yml. This test case verifies that MAC expires within 10 mins if traffic is not flowing using it. Signed-off-by: Praveen Chaudhary<[email protected]> * [fdb_mac_expire.yml]: FDB MAC Expire test case. [fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table. [testcases.yml]: include fdb_mac_expire.yml. This test case verifies that MAC expires within 10 mins if traffic is not flowing using it. Signed-off-by: Praveen Chaudhary<[email protected]> * [fdb_mac_expire.yml]: Incorporate swssconfig step to set fdb_aging_timer in fdb_mac_expire.yml Signed-off-by: Praveen Chaudhary<[email protected]> * [fdb_mac_expire.yml]: minor changes in logs Signed-off-by: Praveen Chaudhary<[email protected]> * [fdb_mac_expire.yml]: minor log changes to show time correctly. Example: "MAC Entires are Cleared within 100 secs." instead of "MAC Entires are Cleared within 2*50 secs." Signed-off-by: Praveen Chaudhary<[email protected]> * [fdb_mac_expire.yml]: Address review comments related to sonic-clear, -it option and block-always. Signed-off-by: Praveen Chaudhary<[email protected]> * [fdb_mac_expire.yml]: Change "sonic-clear fdb all" to "Clear FDB table". Signed-off-by: Praveen Chaudhary<[email protected]>
[fdb_mac_expire.yml]: FDB MAC Expire test case.
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table.
[fdb.yml]: include fdb_mac_expire.yml.
This test case verifies that MAC expires within 10 mins if traffic
is not flowing using it.
Signed-off-by: Praveen Chaudhary[email protected]
Description of PR
Test Case for sonic-net/sonic-buildimage#2365
Summary:
Added new file fdb_mac_expire.yml to keep FDB MAC Expire test case separate.
[fdb_mac_expire_test.py]: PTF helper to add dummy Macs in L2 table. I used separate ptf file to generate traffic for dummy mac.
[fdb.yml]: include fdb_mac_expire.yml. I included fdb_mac_expire.yml with condition when parameter run_fdb_mac_expire is set to True.
Fixes # (issue)
Type of change
Approach
How did you do it?
Added new file fdb_mac_expire.yml to keep FDB MAC Expire test case separate.
[fdb_mac_expire_test.py]: PTF helper to add Mac in L2 table. I used separate ptf file to generate traffic for dummy mac.
[fdb.yml]: include fdb_mac_expire.yml. I included fdb_mac_expire.yml with condition when parameter run_fdb_mac_expire is set to True.
How did you verify/test it?
Results:
Had T0 FDB run:
Snippet from Run:
TestCase Result Update after Changes done to address Review Comment:
snippet:
Test results summary after commit 9:
Any platform specific information?
No
Supported testbed topology if it's a new test case?
T0
Documentation
Part of FDB.
Related PR: sonic-net/sonic-buildimage#2365