-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix loganalyzer.py UnicodeDecodeError issue" #6577
Conversation
This reverts commit 94ac4a0.
The pre-commit check detected issues in the files touched by this pull request. For old issues, it is not mandatory to fix them because they were not caused by this change. It is unfair to blame Detailed pre-commit check results: To run the pre-commit checks locally, you can follow below steps:
|
…" (#6611) Reverts #6577 It blocks smoke test since the image fix sonic-net/sonic-buildimage#12425 is not in internal branch.
…" (#6611) Reverts #6577 It blocks smoke test since the image fix sonic-net/sonic-buildimage#12425 is not in internal branch.
…c-net#6577) This reverts commit 94ac4a0.
…" (sonic-net#6577)" (sonic-net#6611) Reverts sonic-net#6577 It blocks smoke test since the image fix sonic-net/sonic-buildimage#12425 is not in internal branch.
…c-net#6577) This reverts commit 94ac4a0.
Reverts #6524
Non utf-8 characters are not expected in syslog, we should not ignore this kind of errors.
Revert this PR to make sure we can catch this issue in nightly test in future.