Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sonic-utilities] Add test case for show and sonic-installer not depends on database docker #5722

Closed
wants to merge 7 commits into from

Conversation

liuh-80
Copy link
Contributor

@liuh-80 liuh-80 commented May 26, 2022

Description of PR

Add new E2E test cases to test show and sonic-installer not depends on database docker.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

Add new E2E test cases to test show and sonic-installer not depends on database docker.

How did you do it?

Add new E2E test case to cover user scenarios.

How did you verify/test it?

Run new UT make sure they are all pass.
Make sure all current UT not break during merge validation.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

Approach

What is the motivation for this PR?

Add E2E test case coverage for SSH login session limit.

How did you do it?

Add new E2E test case to cover user scenarios.

How did you verify/test it?

Run new UT make sure they are all pass.
Make sure all current UT not break during merge validation.

Any platform specific information?

N/A

Supported testbed topology if it's a new test case?

@liuh-80
Copy link
Contributor Author

liuh-80 commented May 26, 2022

These new test case need can pass after this PR finish:
sonic-net/sonic-utilities#2183

@qiluo-msft qiluo-msft changed the title [ sonic-utilities]Add UT to test show and sonic-installer not depends on database docker [sonic-utilities] Add test case for show and sonic-installer not depends on database docker Jun 1, 2022
qiluo-msft
qiluo-msft previously approved these changes Jun 1, 2022
@liuh-80
Copy link
Contributor Author

liuh-80 commented Jun 10, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@qiluo-msft
Copy link
Contributor

It this PR ready to merge?

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 11, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 11, 2022

Will complete this PR when validation passed.

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 12, 2022

The new UT failed when wait key procress restart, this does not happen with local devbox, will increase wait time.

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 12, 2022

New UT keeps failed in following code, can't reproduce on local devbox, need investigation and fix:
# reload config, because some critical process not work after database docker restart
config_reload(duthost)
time.sleep(CONFIG_RELOAD_WAIT_TIME)

  wait_critical_processes(duthost) <== failed here

@liuh-80
Copy link
Contributor Author

liuh-80 commented Jul 25, 2022

/azp run

@azure-pipelines
Copy link

Pull request contains merge conflicts.

@liuh-80
Copy link
Contributor Author

liuh-80 commented Sep 23, 2022

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@liuh-80
Copy link
Contributor Author

liuh-80 commented Sep 23, 2022

Close PR because EasyCLA issue, will create new PR later.

@liuh-80 liuh-80 closed this Sep 23, 2022
@liuh-80
Copy link
Contributor Author

liuh-80 commented Sep 26, 2022

Create sonic-utilities UT here: sonic-net/sonic-utilities#2401

@liuh-80 liuh-80 deleted the dev/liuh/add_show_and_installer_ut branch October 21, 2022 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants