Add ECN WRED configuration test #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires sonic-net/sonic-buildimage#1226 to work properly on Mellanox switch |
yxieca
reviewed
Jan 24, 2018
| @@ -0,0 +1,14 @@ | |||
| -- this lua script is used in qosconfig test | |||
| -- it automates walking thru WRED ojgects in the ASIC DB | |||
yxieca
reviewed
Jan 24, 2018
ansible/roles/test/tasks/sonic.yml
Outdated
| - name: Test QoS Config and utility test | ||
| include: qos_config.yml | ||
| tags: qosconfig | ||
|
|
There was a problem hiding this comment.
Can you also add an access point of this test case in test by test name infrastructure?
I think you need to change following file:
- https://github.com/Azure/sonic-mgmt/blob/master/ansible/roles/test/vars/testcases.yml
This file organizes test cases in alphabetic order.You can following any existing test case as example.
Thanks,
Ying
yxieca
reviewed
Jan 24, 2018
| - name: Check if ASIC DB configured qos parameters | ||
| shell: docker exec database redis-cli -n 1 KEYS ASIC_STATE:SAI_OBJECT_TYPE_QUEUE* | grep QUEUE | ||
| register: grep_queue | ||
| failed_when: grep_queue.rc != 0 |
There was a problem hiding this comment.
I am not sure if this is a big deal or not. But we do have some devices doesn't yet have qos config.
Failing test on a dut which doesn't have qos config seems to be too harsh?
Is there a way to early exit instead of failing the test?
Please don't spend too much time on this question. It is a very minor issue. I am ok with it not fixed.
yxieca
reviewed
Jan 24, 2018
andriymoroz-mlnx
force-pushed
the
wred_config_test
branch
from
15480d0 to
3b9366f
Compare
andriymoroz-mlnx
changed the title
Signed-off-by: Andriy Moroz <[email protected]>
andriymoroz-mlnx
force-pushed
the
wred_config_test
branch
from
3b9366f to
cc00eed
Compare
yxieca
approved these changes
Jan 31, 2018
yxieca
approved these changes
Jan 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andriy Moroz [email protected]
Description of PR
Tests for the QoS/ECN configuration and ecnconfig utility
Type of change
Approach
How did you verify/test it?
ansible-playbook test_sonic.yml -i inventory --limit {DUT_NAME} --become --tags ecn_wredAny platform specific information?
Platform independent. Requires SAI support set for ECN/WRED parameters
Supported testbed topology if it's a new test case?
Topology independent
Documentation
Test plan:
QoS configuration in Config DB. ECN WRED configuration utility test plan