[test] Add lacp fallback test cases #379
Conversation
|
@rodnymolina Could you please help review the test plan? Thanks, |
|
can you add to REAME.test.md for how to run the test? |
|
@lguohan Thanks for the reminder. Just added the instruction to REAME.test.md. This test case will run as part of the LAG-2 test cases on t0 topo. Thanks, |
hzheng5
force-pushed
the
lacp-fallback-test
branch
from
23b9598 to
f3c3d64
Compare
|
Can you please resolve the conflict? |
ansible/templates/topo/t0.j2
Outdated
| @@ -116,6 +116,9 @@ | |||
| <PortChannel> | |||
| <Name>PortChannel{{ ((index+1)|string).zfill(4) }}</Name> | |||
| <AttachTo>{{ port_alias[28+index] }}</AttachTo> | |||
| {% if index%2 %} | |||
There was a problem hiding this comment.
Fallback is enabled only when we have odd index?
Can you please comment what is this like do?
There was a problem hiding this comment.
yes. only enable fallback on odd ports here, so we can compare the status between odd ports and even ports to make sure both are in expected state.
Thanks for the suggestion. Will add some comment here.
ansible/README.test.md
Outdated
| @@ -83,6 +83,13 @@ ansible-playbook test_sonic.yml -i inventory --limit {DUT_NAME} --tags lag-2 --e | |||
| ``` | |||
| - Requires switch connected to a VM testbed with lag configured (t0, t1-lag) | |||
|
|
|||
| ### Lag-fallback test | |||
| ``` | |||
| ansible-playbook test_sonic.yml -i inventory --limit {DUT_NAME} --tags lag-2 --extra-vars "testbed_type={TESTBED_TYPE} ptf_host={PTF_HOST}" | |||
There was a problem hiding this comment.
You need to convert your test into new format
ansible-playbook test_sonic.yml -i str --limit str-s6100-acs-1 --vault-password-file password.txt -e testcase_name=lag-2 -e testbed_name=vms3-t0-s6100
Please check how the recently added tests are executed. Please let me know if you have questions.
There was a problem hiding this comment.
sure. Thanks @pavel-shirshov
will rewrite the test case
hzheng5
force-pushed
the
lacp-fallback-test
branch
from
a451dd9 to
2f2f25b
Compare
|
@pavel-shirshov I closed this pull request since the code is too old and has some conflicts. Please review the latest pull request #1187 instead, thanks |
Please note min_port and fallback configure are mutual exclusive
for each lag.
Depends on sonic-net/sonic-buildimage#1118
Signed-off-by: Haiyang Zheng [email protected]
Description of PR
Fixes # (issue)
Type of change
Approach
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation