Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sonic-mgmt test cases for express-reboot #15918

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jhli-cisco
Copy link
Contributor

@jhli-cisco jhli-cisco commented Dec 5, 2024

Description of PR

New set of test cases to test express boot feature. It covers the same scenario as in test_advanced_reboot for warm-reboot.

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Test cases for express boot feature

How did you do it?

Create a new set of test cases

How did you verify/test it?

Run through it using an image that supports express boot

Any platform specific information?

Supported testbed topology if it's a new test case?

t0

Documentation

@jhli-cisco jhli-cisco requested a review from prgeor as a code owner December 5, 2024 19:11
@mssonicbld
Copy link
Collaborator

The pre-commit check detected issues in the files touched by this pull request.
The pre-commit check is a mandatory check, please fix detected issues.

Detailed pre-commit check results:
trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check yaml...........................................(no files to check)Skipped
check for added large files..............................................Passed
check python ast.........................................................Passed
flake8...................................................................Failed
- hook id: flake8
- exit code: 1

ansible/roles/test/files/ptftests/py3/advanced-reboot.py:22:121: E501 line too long (122 > 120 characters)
ansible/roles/test/files/ptftests/py3/advanced-reboot.py:1356:121: E501 line too long (126 > 120 characters)
ansible/roles/test/files/ptftests/py3/advanced-reboot.py:1372:121: E501 line too long (126 > 120 characters)
tests/common/fixtures/ptfhost_utils.py:341:121: E501 line too long (145 > 120 characters)
tests/platform_tests/test_express_reboot.py:60:1: E266 too many leading '#' for block comment

flake8...............................................(no files to check)Skipped
check conditional mark sort..........................(no files to check)Skipped

To run the pre-commit checks locally, you can follow below steps:

  1. Ensure that default python is python3. In sonic-mgmt docker container, default python is python2. You can run
    the check by activating the python3 virtual environment in sonic-mgmt docker container or outside of sonic-mgmt
    docker container.
  2. Ensure that the pre-commit package is installed:
sudo pip install pre-commit
  1. Go to repository root folder
  2. Install the pre-commit hooks:
pre-commit install
  1. Use pre-commit to check staged file:
pre-commit
  1. Alternatively, you can check committed files using:
pre-commit run --from-ref <commit_id> --to-ref <commit_id>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants